Skip to content

WSLA: Resolve issue preventing boot from pmem vhds #14036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benhillis merged 1 commit into from
Jan 9, 2026
+5 −9
Merged

WSLA: Resolve issue preventing boot from pmem vhds #14036

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions src/windows/wslaservice/exe/WSLAVirtualMachine.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,14 +309,13 @@ void WSLAVirtualMachine::Start()
}
else
{
hcs::VirtualPMemController pmemController;
pmemController.MaximumCount = 0;
pmemController.MaximumSizeBytes = 0;
hcs::VirtualPMemController pmemController{};
pmemController.Backing = hcs::VirtualPMemBackingType::Virtual;
ULONG nextDeviceId = 0;
auto attachPmemDisk = [&](PCWSTR path) {
ULONG deviceId = pmemController.MaximumCount;
pmemController.MaximumCount += 1;
hcs::VirtualPMemDevice vhd;
auto deviceId = nextDeviceId;
nextDeviceId += 1;
hcs::VirtualPMemDevice vhd{};
vhd.HostPath = path;
vhd.ReadOnly = true;
vhd.ImageFormat = hcs::VirtualPMemImageFormat::Vhd1;
Expand Down
3 changes: 0 additions & 3 deletions test/windows/WSLATests.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1028,9 +1028,6 @@ class WSLATests
{
WSL2_TEST_ONLY();

LogSkipped("Skipping pmem test since mounting the WSLA VHD currently fails");
return;

// Test with SCSI boot VHDs.
{
auto settings = GetDefaultSessionSettings();
Expand Down