Skip to content

Fix HelmInstaller@1 when GitHub is unvailable or rate limited #479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Fix HelmInstaller@1 when GitHub is unvailable or rate limited #479

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e096b21
Throw an error when unable to retrieve the helm releases instead of d…
jraycroft Aug 13, 2025
6a5e273
update version number
jraycroft Aug 13, 2025
b39dfd7
Get latest helm version if version isn't specified.
jraycroft Aug 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 7 additions & 20 deletions common-npm-packages/kubernetes-common/helmutility.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,7 @@ const semver = require('semver');
tl.setResourcePath(path.join(__dirname, 'module.json'), true);

const helmToolName = 'helm';
const helmAllReleasesUrl = 'https://api.github.com/repos/helm/helm/releases';
const stableHelmVersion = 'v3.1.2';
const helmLatestReleaseUrl = 'http://get.helm.sh/helm-latest-version';

export async function getHelm(version?: string) {
try {
Expand Down Expand Up @@ -70,36 +69,24 @@ function getHelmDownloadURL(version: string): string {
}

export async function getStableHelmVersion(): Promise<string> {
let latestHelmVersion = '';
try {
const downloadPath = await toolLib.downloadTool(helmAllReleasesUrl);
const responseArray = JSON.parse(fs.readFileSync(downloadPath, 'utf8').toString().trim());
let latestHelmVersion = semver.clean(stableHelmVersion);
responseArray.forEach(response => {
if (response && response.tag_name) {
let currentHelmVerison = semver.clean(response.tag_name.toString());
if (currentHelmVerison) {
if (currentHelmVerison.toString().indexOf('rc') == -1 && semver.gt(currentHelmVerison, latestHelmVersion)) {
//If current helm version is not a pre release and is greater than latest helm version
latestHelmVersion = currentHelmVerison;
}
}
}
});
latestHelmVersion = "v" + latestHelmVersion;
const downloadPath = await toolLib.downloadTool(helmLatestReleaseUrl);
latestHelmVersion = fs.readFileSync(downloadPath, 'utf8').toString().trim();
return latestHelmVersion;
} catch (error) {
let telemetry = {
event: "HelmLatestNotKnown",
url: helmAllReleasesUrl,
url: helmLatestReleaseUrl,
error: error
};
console.log("##vso[telemetry.publish area=%s;feature=%s]%s",
"TaskEndpointId",
"HelmInstaller",
JSON.stringify(telemetry));

tl.warning(tl.loc('HelmLatestNotKnown', helmAllReleasesUrl, error, stableHelmVersion));
tl.error(tl.loc('HelmLatestNotKnown', helmLatestReleaseUrl, error));
}

return stableHelmVersion;
return latestHelmVersion;
}
2 changes: 1 addition & 1 deletion common-npm-packages/kubernetes-common/module.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"KubectlClientVersion": "Kubectl Client Version",
"KubectlServerVersion": "Kubectl Server Version",
"KubectlServerVerisonNotFound": "Could not find kubectl server version",
"HelmLatestNotKnown": "Cannot get the latest Helm info from %s. Error %s. Using default Helm version %s.",
"HelmLatestNotKnown": "Cannot get the latest Helm info from %s. Error %s.",
"HelmDownloadFailed": "Failed to download Helm from location %s. Error %s",
"HelmNotFoundInFolder": "Helm executable not found in path %s",
"DownloadStableVersionFailed": "Failed to read latest kubectl version from stable.txt. From URL %s. Using default stable version %s.",
Expand Down
4 changes: 2 additions & 2 deletions common-npm-packages/kubernetes-common/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion common-npm-packages/kubernetes-common/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "azure-pipelines-tasks-kubernetes-common",
"version": "2.256.0",
"version": "2.262.0",
"description": "Common Library for Kubernetes",
"repository": {
"type": "git",
Expand Down