-
Notifications
You must be signed in to change notification settings - Fork 589
Enable building systemd-ukify and systemd-boot on ARM64 #14449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 3.0-dev
Are you sure you want to change the base?
Conversation
Signed-off-by: Chris Co <[email protected]>
Signed-off-by: Chris Co <[email protected]>
98e7604
to
ac93f0b
Compare
<!-- Description: Please provide a summary of the changes and the motivation behind them. --> Adding fix for arm64 UKI support. This adds dynamic setting of the stub filepaths based on architecture. systemd-ukify and systemd-boot will be added to azurelinux arm64 with this PR: microsoft/azurelinux#14449 --- ### **Checklist** - [ ] Tests added/updated - [ ] Documentation updated (if needed) - [ ] Code conforms to style guidelines --------- Co-authored-by: Chris Gunn <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider dropping the changes in systemd-boot-signed and just bumping the release number on the spec for the time being.
Then once you've hooked up the infra side to produce the signed systemd-bootaa64.efi binary, you can make this update to systemd-boot-signed so we start getting officially signed systemd-bootaa64.efi artifacts.
cp %{buildroot}/usr/lib/systemd/boot/efi/systemd-bootx64.efi %{buildroot}/boot/efi/EFI/BOOT/grubx64.efi | ||
%elifarch aarch64 | ||
cp %{buildroot}/usr/lib/systemd/boot/efi/systemd-bootaa64.efi %{buildroot}/boot/efi/EFI/BOOT/grubaa64.efi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The copy step for source1 into systemd-bootaa64.efi on aarch64 is missing, thus making this step copy the unsigned version of systemd-bootaa64.efi from the original RPM (source0), instead of the signed version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Taking note for when we come back to systemd-boot-signed with these changes. Thank you Chris!
ac93f0b
to
c9a243c
Compare
Dropped changes as per recommendation. Release has been bumped to align with systemd.spec |
🚨 PR Check Failed - Critical Issues FoundFound 1 critical/error issue(s) that must be fixed. 🔍 Critical Issues Detected:
🤖 AI Analysis Summary:Brief Analysis: Critical Issues Found: Recommended Actions: 📋 For detailed analysis and recommendations, check the Azure DevOps pipeline logs. |
This appears to be a false alarm. '26494.patch' is present in How does this play with RPM? This has been in the spec since 255, so I'm curious if this issue is benign. EDIT: Further review shows that this Patch path format follow similarly to our Seperately, CBLMariner-Bot also raised concerns over a missing CVE-2023-7008 patch. This is also a false alarm, the patch was contributed 7 months ago and still exists and is being applied. |
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-static
subpackages, etc.) have had theirRelease
tag incremented../cgmanifest.json
,./toolkit/scripts/toolchain/cgmanifest.json
,.github/workflows/cgmanifest.json
)./LICENSES-AND-NOTICES/SPECS/data/licenses.json
,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md
,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON
)*.signatures.json
filessudo make go-tidy-all
andsudo make go-test-coverage
passSummary
This PR updates systemd to build systemd-ukify and systemd-boot for both ARM64 architecture as well as the original x86_64 architecture. Additionally, systemd-boot-signed is updated to enable building on aarch64.
Signed-off-by: Sean Dougherty [email protected]
Does this affect the toolchain?
NO
Associated issues
Test Methodology