Skip to content

Reduce log level for per file level logs in RustSbomDetector #1603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AMaini503 wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Reduce log level for per file level logs in RustSbomDetector #1603

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
abc9a23
Reduce log level for per file level logs in RustSbomDetector
Jan 7, 2026
4808c87
Reduce log level for fallback ownership
Jan 7, 2026
1e4c1c9
Fix RustSbom UTs
Jan 7, 2026
02cdee5
CR: Remove unecessary log
Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Microsoft.ComponentDetection.Detectors/rust/Parsers/RustSbomParser.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,7 +265,7 @@ private void ApplyOwners(

if (!ownersApplied)
{
this.logger.LogWarning("Falling back to SBOM recorder for {Id} because no ownership found", id);
this.logger.LogDebug("Falling back to SBOM recorder for {Id} because no ownership found", id);

// Fallback to SBOM recorder if no ownership info
fallbackRecorder.RegisterUsage(
Expand Down
4 changes: 1 addition & 3 deletions src/Microsoft.ComponentDetection.Detectors/rust/RustSbomDetector.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,8 +252,6 @@ protected override async Task OnFileFoundAsync(
var normDirectory = this.pathUtilityService.NormalizePath(directory);
var fileName = Path.GetFileName(location);

this.Logger.LogInformation("Processing file: {Location}", normLocation);

// Determine file kind
FileKind fileKind;
if (fileName.Equals(CargoTomlFileName, this.pathComparison))
Expand All @@ -272,7 +270,7 @@ protected override async Task OnFileFoundAsync(
// Check if directory should be skipped
if (this.ShouldSkip(directory, fileKind, location))
{
this.Logger.LogInformation("Skipping file due to skip rules: {Location}", normLocation);
this.Logger.LogDebug("Skipping file due to skip rules: {Location}", normLocation);

// Increment skip counters
switch (fileKind)
Expand Down
4 changes: 2 additions & 2 deletions test/Microsoft.ComponentDetection.Detectors.Tests/RustSbomParserTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -824,7 +824,7 @@ await this.parser.ParseWithOwnershipAsync(
// Verify logger warning was called
this.logger.Verify(
x => x.Log(
LogLevel.Warning,
LogLevel.Debug,
It.IsAny<EventId>(),
It.Is<It.IsAnyType>((v, t) => v.ToString().Contains("Falling back to SBOM recorder")),
It.IsAny<Exception>(),
Expand All @@ -847,7 +847,7 @@ await this.parser.ParseWithOwnershipAsync(
// Verify logger warning was called
this.logger.Verify(
x => x.Log(
LogLevel.Warning,
LogLevel.Debug,
It.IsAny<EventId>(),
It.Is<It.IsAnyType>((v, t) => v.ToString().Contains("Falling back to SBOM recorder")),
It.IsAny<Exception>(),
Expand Down
Loading