[LinkV1] Simplify code to find child string of LinkV1 when setting a11yLabel #3859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rurikoaraki
approved these changes
Feb 20, 2025
ksiler
changed the title
rurikoaraki
approved these changes
Feb 20, 2025
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
Previously, if we didn't find a string as a child of LinkV1 and called .toString(), we ran into an error. This fixes it by simplyfing the code to just return the first child that's a string (if it exists) instead of calling .toString() on the result. We use this to set the a11yLabel if one isn't defined.
Verification
Tested by creating a Link without any children. Verified FURN test app no longer runs into an error.
Pull request checklist
This PR has considered (when applicable):