Skip to content

[LinkV1] Simplify code to find child string of LinkV1 when setting a11yLabel #3859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ksiler merged 3 commits into from
Feb 20, 2025
Merged

[LinkV1] Simplify code to find child string of LinkV1 when setting a11yLabel #3859

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8ffc3c3
Check if we find a string as a child before calling .toString()
ksiler Feb 20, 2025
3011ff2
Change files
ksiler Feb 20, 2025
be4316d
Simplify code to find child string of LinkV1
ksiler Feb 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@fluentui-react-native-link-c18251d2-05a6-485f-a6bc-f471efef105e.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Check if we find a string as a child before calling .toString()",
"packageName": "@fluentui-react-native/link",
"email": "[email protected]",
"dependentChangeType": "patch"
}
9 changes: 6 additions & 3 deletions packages/components/Link/src/Link.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,12 @@ export const Link = compose<LinkType>({
// Find the first child that's a string and save it to set as the link's
// accessibilityLabel if one isn't defined.
let linkA11yLabel = '';
linkA11yLabel = React.Children.toArray(children)
.find((child) => typeof child === 'string')
.toString();

const textChild = React.Children.toArray(children).find((child) => typeof child === 'string');

if (textChild != undefined) {
linkA11yLabel = textChild.toString();
}

return supportsA11yTextInText && supportsInteractionOnText && (inline || mergedProps.selectable) ? (
<Slots.content {...mergedProps}>{children}</Slots.content>
Expand Down
Loading