Skip to content

Conversation

@JasonVMo
Copy link
Contributor

@JasonVMo JasonVMo commented Jul 2, 2025

Platforms Impacted

  • all

Description of changes

Additional Updates 7/3

Some more changes to fix issues with the bundles.

  • QOL improvement added, changed vscode defaults to automatically fix the import ordering and other eslint errors on save.
  • Changed reference to e2e package to be via package rather than direct references. The direct references were causing the internal paths to be extremely deep. More importantly it caused the lib depth to diverge from the src depth causing asset references to fail.
  • Exported things specifically in e2e. Note generating e2e/src/index.ts was done with AI, extremely useful to automate the tediousness of manually exporting everything.

The way TS was set up in fluent-tester, reaching across to the e2e package, caused TS to create a lib structure with lib/e2e/src and lib/fluent-tester/src within the fluent-tester package. It's causes wonky behavior, adding as a reminder to folks to not do this.

Original Description

To update FURN to use the modern jsx runtime it needs to use more modern settings, in particular export maps, which require using node16. This caused a bit of a cascade:

  • Updated the base tsconfig.json to use node16 for module and moduleResolution, this will build commonjs output unless type="module" (which we don't do)
  • We still output ESM -> lib and CJS -> lib-commonjs, now with node16 settings.
  • Updated target to something more modern, babel transforms can handle it as needed.
  • Got rid of the OnPublish stuff, it was done originally to handle jest typing better but updates since, in particular the @rnx-kit/jest-config knows how to handle things correctly.
  • Added export maps for all packages and updated main and module to reference the .js files.
  • Found/fixed a number of typing issues being hidden by our previous settings. In particular the use of TS directly caused unexported types to not always be caught.
  • Removed an unused tsconfig.json at the root.

Verification

Normal build and pipeline runs.

@JasonVMo JasonVMo requested a review from a team as a code owner July 2, 2025 21:36
@JasonVMo JasonVMo enabled auto-merge (squash) July 2, 2025 21:45
@JasonVMo JasonVMo merged commit 479b93c into main Jul 3, 2025
11 checks passed
@JasonVMo JasonVMo deleted the user/jasonvmo/use-node16 branch July 3, 2025 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants