Skip to content

Conversation

@JasonVMo
Copy link
Contributor

@JasonVMo JasonVMo commented Jul 9, 2025

Platforms Impacted

  • all platforms

Description of changes

More engineering system changes and cleanup that I encountered while working on the jsx-runtime work and separated into a more focused PR. This includes a number of changes to the way we build TS in FURN.

This includes the following changes:

  • build typescript by invoking tsc directly rather than going through justScripts
  • cleaned up the typescript options so we are using the tsconfig.json to configure almost everything
  • typescript builds now pick targets based on package.json settings. It uses main/exports.require and module/exports.import to determine whether to build cjs / esm output and where to put that output.
  • did a more comprehensive implementation of external.dependencies.mjs to allow for configuring groups of dependencies to inject in a more extendable way.
  • cleaned up a few package.json entries with things that were wrong.
  • made the babel config more configurable (though the configs remain the same for all packages). The babel settings, in particular the runtime setting, is one of the handlers that determines whether or not to use the new or old jsx runtime behavior.
  • now run the codegen step for both output targets. Previously we were only doing codegen for --outDir lib

Verification

Ran builds, tests, bundles, win32 tester.

@JasonVMo JasonVMo requested a review from a team as a code owner July 9, 2025 07:16
@JasonVMo JasonVMo merged commit 4acbfe3 into main Jul 9, 2025
11 checks passed
@JasonVMo JasonVMo deleted the user/jasonvmo/tsc branch July 9, 2025 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants