Fix linting: finish the conversion to v9 and flat configs, make lint not silently fail and fix a bunch of type errors

.vscode/settings.json

@@ -9,7 +9,7 @@
   },
 
   "eslint.enable": true,
-  "eslint.workingDirectories": [{ "mode": "auto" }], // infer working directory based on .eslintrc/package.json location
+  "eslint.workingDirectories": [{ "pattern": "./packages/framework/eslint-config-rules" }], // use the common eslint config file
 
   "explorer.fileNesting.enabled": true,
   "explorer.fileNesting.patterns": {

apps/E2E/eslint.config.js

@@ -1,3 +1,11 @@
 const baseConfig = require('@fluentui-react-native/eslint-config-rules');
 
-module.exports = baseConfig;
+module.exports = [
+  ...baseConfig,
+  {
+    rules: {
+      '@typescript-eslint/no-duplicate-enum-values': 'off',
+      '@typescript-eslint/no-invalid-void-type': 'off',
+    },
+  },
+];

apps/fluent-tester/src/TestComponents/Badge/BasicBadgeTest.tsx

@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/no-var-requires */
 import React, { useState, useCallback, useMemo } from 'react';
 import { View, Platform, Image } from 'react-native';
 

apps/fluent-tester/src/TestComponents/Badge/CounterBadgeTest.tsx

@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/no-var-requires */
 import React from 'react';
 import { View, Platform, Text } from 'react-native';
 

apps/fluent-tester/src/TestComponents/Badge/PresenceBadgeTest.android.tsx

@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/no-var-requires */
 import React, { useCallback, useState } from 'react';
 import { View, StyleSheet, Text } from 'react-native';
 

apps/fluent-tester/src/TestComponents/Badge/PresenceBadgeTest.tsx

@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/no-var-requires */
 import React, { useState, useCallback } from 'react';
 import { View, Platform, Text } from 'react-native';
 

apps/fluent-tester/src/TestComponents/Button/E2EButtonTest.tsx

@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/no-var-requires */
 import * as React from 'react';
 import { View } from 'react-native';
 

apps/fluent-tester/src/TestComponents/Button/deprecated/ButtonIconTest.tsx

@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/no-var-requires */
 import * as React from 'react';
 import { Platform, View } from 'react-native';
 
@@ -14,8 +13,6 @@ const CustomizedIconButton = Button.customize({
 });
 
 export const ButtonIconTest_deprecated: React.FunctionComponent = () => {
-  /* eslint-disable @typescript-eslint/no-var-requires */
-
   // SVG-based icons are not available on all platforms yet
   const svgIconsEnabled = ['ios', 'macos', 'win32', 'android'].includes(Platform.OS as string);
   const iconProps = { svgSource: svgProps, width: 20, height: 20 };

apps/fluent-tester/src/TestComponents/Button/deprecated/E2EButtonTest.tsx

@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/no-var-requires */
 import * as React from 'react';
 import { View } from 'react-native';
 

apps/fluent-tester/src/TestComponents/Chip/ChipDefault.tsx

@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/no-var-requires */
 import React, { useCallback } from 'react';
 import { StyleSheet, View, ToastAndroid } from 'react-native';
 

apps/fluent-tester/src/TestComponents/ContextualMenu/ContextualMenuTest.tsx

@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/no-var-requires */
 import * as React from 'react';
 import { Text, View, Switch } from 'react-native';
 

apps/fluent-tester/src/TestComponents/ContextualMenu/E2EContextualMenuTest.tsx

@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/no-var-requires */
 import * as React from 'react';
 import { Text, View, Switch } from 'react-native';
 

apps/fluent-tester/src/TestComponents/Icon/IconLegacyE2ETest.tsx

@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/no-var-requires */
 import * as React from 'react';
 import { View } from 'react-native';
 

apps/fluent-tester/src/TestComponents/Icon/IconTest.tsx

@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/no-var-requires */
 import * as React from 'react';
 import { Platform, PlatformColor, View } from 'react-native';
 

apps/fluent-tester/src/TestComponents/Icon/IconV1E2ETest.tsx

@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/no-var-requires */
 import * as React from 'react';
 import { View } from 'react-native';
 

apps/fluent-tester/src/TestComponents/MenuButtonLegacy/testData.ts

@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/no-var-requires */
 import type { MenuButtonItemProps } from '@fluentui/react-native';
 import { MENU_ITEM_1_COMPONENT } from '@fluentui-react-native/e2e-testing';
 

apps/fluent-tester/src/TestComponents/MenuButtonV1/testData.ts

@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/no-var-requires */
 import type { MenuButtonItemProps } from '@fluentui/react-native';
 
 import { testImage, svgProps } from '../Common/iconExamples';

apps/fluent-tester/src/TestComponents/Svg/SvgTest.tsx

@@ -248,6 +248,7 @@ const RemoteSvgTest: React.FunctionComponent = () => {
           style={styles.svg}
           width="100"
           height="100"
+          // eslint-disable-next-line @microsoft/sdl/no-insecure-url
           uri="http://10.122.222.112:8080/accessible-icon-brands.svg"
           accessible={true}
           accessibilityLabel="SVG Uri Test"

change/@fluentui-react-native-adapters-3e6769fd-4d09-4122-8581-9db381a4bf1d.json

@@ -0,0 +1,7 @@
+{
+  "type": "patch",
+  "comment": "fix repo linting with new configs and version, fixing linting errors as well",
+  "packageName": "@fluentui-react-native/adapters",
+  "email": "jasonmo@microsoft.com",
+  "dependentChangeType": "patch"
+}

change/@fluentui-react-native-badge-9e71f599-3e29-44a7-b2fc-b510b0d0f601.json

@@ -0,0 +1,7 @@
+{
+  "type": "patch",
+  "comment": "fix repo linting with new configs and version, fixing linting errors as well",
+  "packageName": "@fluentui-react-native/badge",
+  "email": "jasonmo@microsoft.com",
+  "dependentChangeType": "patch"
+}

change/@fluentui-react-native-button-c1ad771e-45ff-46d8-83b5-0fdccb118fd8.json

@@ -0,0 +1,7 @@
+{
+  "type": "patch",
+  "comment": "fix repo linting with new configs and version, fixing linting errors as well",
+  "packageName": "@fluentui-react-native/button",
+  "email": "jasonmo@microsoft.com",
+  "dependentChangeType": "patch"
+}

change/@fluentui-react-native-chip-832280b9-5bed-4cb7-8e4d-fed76cb126a5.json

@@ -0,0 +1,7 @@
+{
+  "type": "patch",
+  "comment": "fix repo linting with new configs and version, fixing linting errors as well",
+  "packageName": "@fluentui-react-native/chip",
+  "email": "jasonmo@microsoft.com",
+  "dependentChangeType": "patch"
+}

change/@fluentui-react-native-codemods-8d308b4b-cfb2-4f1f-9346-1ff072fed447.json

@@ -0,0 +1,7 @@
+{
+  "type": "patch",
+  "comment": "fix repo linting with new configs and version, fixing linting errors as well",
+  "packageName": "@fluentui-react-native/codemods",
+  "email": "jasonmo@microsoft.com",
+  "dependentChangeType": "patch"
+}

change/@fluentui-react-native-dropdown-27d9b943-560c-4dbf-849d-e967cb0fca57.json

@@ -0,0 +1,7 @@
+{
+  "type": "patch",
+  "comment": "fix repo linting with new configs and version, fixing linting errors as well",
+  "packageName": "@fluentui-react-native/dropdown",
+  "email": "jasonmo@microsoft.com",
+  "dependentChangeType": "patch"
+}

change/@fluentui-react-native-e2e-testing-37de513c-aca4-42e1-a268-d107e2b55d81.json

@@ -0,0 +1,7 @@
+{
+  "type": "patch",
+  "comment": "fix repo linting with new configs and version, fixing linting errors as well",
+  "packageName": "@fluentui-react-native/e2e-testing",
+  "email": "jasonmo@microsoft.com",
+  "dependentChangeType": "patch"
+}

change/@fluentui-react-native-experimental-appearance-additions-cf6a2762-71cd-4094-8117-404c7a16e5ba.json

@@ -0,0 +1,7 @@
+{
+  "type": "patch",
+  "comment": "fix repo linting with new configs and version, fixing linting errors as well",
+  "packageName": "@fluentui-react-native/experimental-appearance-additions",
+  "email": "jasonmo@microsoft.com",
+  "dependentChangeType": "patch"
+}

change/@fluentui-react-native-focus-zone-768810b8-9093-4939-a910-cab9fd6d8dcf.json

@@ -0,0 +1,7 @@
+{
+  "type": "patch",
+  "comment": "fix repo linting with new configs and version, fixing linting errors as well",
+  "packageName": "@fluentui-react-native/focus-zone",
+  "email": "jasonmo@microsoft.com",
+  "dependentChangeType": "patch"
+}

change/@fluentui-react-native-framework-a52d2934-bf00-442c-b88b-d196b4f103e0.json

@@ -0,0 +1,7 @@
+{
+  "type": "patch",
+  "comment": "fix repo linting with new configs and version, fixing linting errors as well",
+  "packageName": "@fluentui-react-native/framework",
+  "email": "jasonmo@microsoft.com",
+  "dependentChangeType": "patch"
+}

change/@fluentui-react-native-immutable-merge-c2268509-58df-4bc3-9d22-373050f9ab8d.json

@@ -0,0 +1,7 @@
+{
+  "type": "patch",
+  "comment": "fix repo linting with new configs and version, fixing linting errors as well",
+  "packageName": "@fluentui-react-native/immutable-merge",
+  "email": "jasonmo@microsoft.com",
+  "dependentChangeType": "patch"
+}

change/@fluentui-react-native-interactive-hooks-ae27cfa5-bf28-4a25-a0fd-431e62b90884.json

@@ -0,0 +1,7 @@
+{
+  "type": "patch",
+  "comment": "fix repo linting with new configs and version, fixing linting errors as well",
+  "packageName": "@fluentui-react-native/interactive-hooks",
+  "email": "jasonmo@microsoft.com",
+  "dependentChangeType": "patch"
+}

change/@fluentui-react-native-link-60d1ec07-cc43-4c24-a83d-16b05544e9ab.json

@@ -0,0 +1,7 @@
+{
+  "type": "patch",
+  "comment": "fix repo linting with new configs and version, fixing linting errors as well",
+  "packageName": "@fluentui-react-native/link",
+  "email": "jasonmo@microsoft.com",
+  "dependentChangeType": "patch"
+}

change/@fluentui-react-native-memo-cache-a7d6b9d9-7a56-402d-b67b-d73f0c3ae745.json

@@ -0,0 +1,7 @@
+{
+  "type": "patch",
+  "comment": "fix repo linting with new configs and version, fixing linting errors as well",
+  "packageName": "@fluentui-react-native/memo-cache",
+  "email": "jasonmo@microsoft.com",
+  "dependentChangeType": "patch"
+}

change/@fluentui-react-native-menu-a1c6c0a4-95bb-4486-bbcf-a53e92ad6bb7.json

@@ -0,0 +1,7 @@
+{
+  "type": "patch",
+  "comment": "fix repo linting with new configs and version, fixing linting errors as well",
+  "packageName": "@fluentui-react-native/menu",
+  "email": "jasonmo@microsoft.com",
+  "dependentChangeType": "patch"
+}

change/@fluentui-react-native-merge-props-7d1376dc-5b1e-4cb5-b8ba-5b34ed880632.json

@@ -0,0 +1,7 @@
+{
+  "type": "patch",
+  "comment": "fix repo linting with new configs and version, fixing linting errors as well",
+  "packageName": "@fluentui-react-native/merge-props",
+  "email": "jasonmo@microsoft.com",
+  "dependentChangeType": "patch"
+}

change/@fluentui-react-native-popover-0c8d05cb-5282-419d-a50d-4795a0a864f0.json

@@ -0,0 +1,7 @@
+{
+  "type": "patch",
+  "comment": "fix repo linting with new configs and version, fixing linting errors as well",
+  "packageName": "@fluentui-react-native/popover",
+  "email": "jasonmo@microsoft.com",
+  "dependentChangeType": "patch"
+}

change/@fluentui-react-native-pressable-a4120a74-65da-47fc-a4f1-209de9dcfd2a.json

@@ -0,0 +1,7 @@
+{
+  "type": "patch",
+  "comment": "fix repo linting with new configs and version, fixing linting errors as well",
+  "packageName": "@fluentui-react-native/pressable",
+  "email": "jasonmo@microsoft.com",
+  "dependentChangeType": "patch"
+}

change/@fluentui-react-native-radio-group-11894281-4261-4f73-9294-e2010a724af3.json

@@ -0,0 +1,7 @@
+{
+  "type": "patch",
+  "comment": "fix repo linting with new configs and version, fixing linting errors as well",
+  "packageName": "@fluentui-react-native/radio-group",
+  "email": "jasonmo@microsoft.com",
+  "dependentChangeType": "patch"
+}

change/@fluentui-react-native-stack-89710f69-d4b7-4289-a6a8-db8535bfafcc.json

@@ -0,0 +1,7 @@
+{
+  "type": "patch",
+  "comment": "fix repo linting with new configs and version, fixing linting errors as well",
+  "packageName": "@fluentui-react-native/stack",
+  "email": "jasonmo@microsoft.com",
+  "dependentChangeType": "patch"
+}

change/@fluentui-react-native-tablist-0a87735d-4501-49a2-bdee-4f89cfeeeab2.json

@@ -0,0 +1,7 @@
+{
+  "type": "patch",
+  "comment": "fix repo linting with new configs and version, fixing linting errors as well",
+  "packageName": "@fluentui-react-native/tablist",
+  "email": "jasonmo@microsoft.com",
+  "dependentChangeType": "patch"
+}

change/@fluentui-react-native-tester-0e76f426-0103-4261-8d07-d8510997e418.json

@@ -0,0 +1,7 @@
+{
+  "type": "patch",
+  "comment": "fix repo linting with new configs and version, fixing linting errors as well",
+  "packageName": "@fluentui-react-native/tester",
+  "email": "jasonmo@microsoft.com",
+  "dependentChangeType": "patch"
+}

change/@fluentui-react-native-theme-tokens-1f9944bb-4a08-484d-9a01-1dcc5b55d3e8.json

@@ -0,0 +1,7 @@
+{
+  "type": "patch",
+  "comment": "fix repo linting with new configs and version, fixing linting errors as well",
+  "packageName": "@fluentui-react-native/theme-tokens",
+  "email": "jasonmo@microsoft.com",
+  "dependentChangeType": "patch"
+}

change/@fluentui-react-native-theme-types-492f6917-4850-46d2-bca8-e1553c1fbbf4.json

@@ -0,0 +1,7 @@
+{
+  "type": "patch",
+  "comment": "fix repo linting with new configs and version, fixing linting errors as well",
+  "packageName": "@fluentui-react-native/theme-types",
+  "email": "jasonmo@microsoft.com",
+  "dependentChangeType": "patch"
+}

change/@fluentui-react-native-themed-stylesheet-2aca423d-cf34-471b-82b4-8da39e0345f8.json

@@ -0,0 +1,7 @@
+{
+  "type": "patch",
+  "comment": "fix repo linting with new configs and version, fixing linting errors as well",
+  "packageName": "@fluentui-react-native/themed-stylesheet",
+  "email": "jasonmo@microsoft.com",
+  "dependentChangeType": "patch"
+}