fix: Overlay NavDrawer needs to preserve dialog role #34942
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
The overlay variant of NavDrawer overrode the underlying Drawer's
role=dialog
, which is required for a lot of built-in screen reader behavior around virtual cursor behavior and setting user expectations for being in a modal dialog. Without the role,aria-modal=true
also doesn't really do anything.New Behavior
NavDrawer keeps
role=dialog
, and therole=navigation
is moved toNavDrawerBody
. While that means the header is no longer part of the navigation region, that seems generally fine to me.Related Issue(s)
None, noticed this while working on a different FAI bug.