Expose Recovery and Failover Status #1087
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vazois
force-pushed
the
vazois/expose-recovery
branch
4 times, most recently
from
d22bcc1 to
9400006
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR exposes additional recovery and failover status information by introducing new enum values for recovery status and updating related logging and error handling. It also addresses a race condition when acquiring the recovery lock by adding a parameterized StartRecovery method.
- Adds a new RecoveryStatus enum with states for various recovery phases.
- Updates FailoverStatus and its usage in logs and metrics.
- Modifies ReplicationManager, FailoverManager, and other related modules to use the new status values.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| libs/cluster/Server/Replication/RecoveryStatus.cs | Introduces the RecoveryStatus enum with new statuses, including minor comment typos. |
| libs/cluster/Server/Failover/FailoverStatus.cs | Adds new failover statuses and updates the status mapping in GetFailoverStatus. |
| libs/cluster/Server/Replication/ReplicationManager.cs | Updates StartRecovery to accept a RecoveryStatus parameter and logs the status accordingly. |
| libs/cluster/Server/Failover/FailoverManager.cs | Exposes a new lastFailoverStatus field and adds a getter for it. |
| libs/cluster/Server/ClusterProvider.cs | Adds recovery and failover metrics via the updated replication info. |
| libs/cluster/Server/Failover/ReplicaFailoverSession.cs | Updates the call to StartRecovery with a specific RecoveryStatus value and controls the recovery lock release accordingly. |
| libs/cluster/Server/ClusterManagerWorkerState.cs | Modifies the StartRecovery call to use a specific failure recovery status. |
| libs/cluster/Session/ReplicaOfCommand.cs | Adjusts the call to StartRecovery using the appropriate RecoveryStatus. |
vazois
force-pushed
the
vazois/expose-recovery
branch
2 times, most recently
from
c416eb2 to
02525f8
Compare
badrishc
approved these changes
Mar 13, 2025
vazois
force-pushed
the
vazois/expose-recovery
branch
2 times, most recently
from
fa897e7 to
22d30dc
Compare
vazois
force-pushed
the
vazois/expose-recovery
branch
from
22d30dc to
011c5ea
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two new informational fields related to failover and recovery status.
In addition, fixes a race condition when acquiring the recovery lock.