Fix panic in HasConfidentialPolicy for LCOW. #2537
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`HasConfidentialPolicy` assumed that the UVM creation options saved in the UtilityVM struct will always be of type `OptionsWCOW` & `OptionsLCOW`. However, for LCOW we store the options as a pointer (i.e type `*OptionsLCOW`) whereas for WCOW we store the options as a value (i.e type `OptionsWCOW`). This caused the `HasConfidentialPolicy` method to panic when testing the policy for LCOW UtilityVM types. Easy fix would be to just update the switch case to `*OptionsLCOW` instead of `OptionsLCOW`, but it seems better to use the same type (create options pointer) for both LCOW & WCOW to avoid such issues in future. In the long run we also want to refactor this and have a common set of methods/types for handling confidential options for LCOW & WCOW. Signed-off-by: Amit Barve <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a panic in the HasConfidentialPolicy method for LCOW (Linux Containers on Windows) by standardizing how UVM creation options are stored. The issue occurred because LCOW stored options as pointers while WCOW stored them as values, causing type assertion failures.
Key changes:
- Updated type assertions in
HasConfidentialPolicyto expect pointer types for both WCOW and LCOW - Modified WCOW creation to store options as a pointer instead of a value
- Updated existing WCOW option access to use pointer dereference
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| internal/uvm/security_policy.go | Fixed type assertions to expect *OptionsWCOW and *OptionsLCOW pointer types |
| internal/uvm/create_wcow.go | Changed storage of WCOW options from value to pointer |
| internal/uvm/start.go | Updated WCOW option access to use pointer dereference syntax |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
helsaawy
approved these changes
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HasConfidentialPolicyassumed thatthe UVM creation options saved in the UtilityVM struct will always be of type
OptionsWCOW&OptionsLCOW. However, for LCOW we store the options as a pointer (i.e type*OptionsLCOW) whereas for WCOW we store the options as a value (i.e typeOptionsWCOW). This caused theHasConfidentialPolicymethod to panic when testing the policy for LCOW UtilityVM types.Easy fix would be to just update the switch case to
*OptionsLCOWinstead ofOptionsLCOW, but it seems better to use the same type (create options pointer) for both LCOW & WCOW to avoid such issues in future. In the long run we also want to refactor this and have a common set of methods/types for handling confidential options for LCOW & WCOW.