Skip to content

Fix panic in HasConfidentialPolicy for LCOW. #2537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ambarve merged 1 commit into from
Oct 13, 2025
Merged

Fix panic in HasConfidentialPolicy for LCOW. #2537

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/uvm/create_wcow.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -505,7 +505,7 @@ func CreateWCOW(ctx context.Context, opts *OptionsWCOW) (_ *UtilityVM, err error
devicesPhysicallyBacked: opts.FullyPhysicallyBacked,
vsmbNoDirectMap: opts.NoDirectMap,
noWritableFileShares: opts.NoWritableFileShares,
createOpts: *opts,
createOpts: opts,
blockCIMMounts: make(map[string]*UVMMountedBlockCIMs),
}

Expand Down
4 changes: 2 additions & 2 deletions internal/uvm/security_policy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,9 +167,9 @@ func (uvm *UtilityVM) InjectPolicyFragment(ctx context.Context, fragment *ctrdta
// returns if this instance of the UtilityVM is created with confidential policy
func (uvm *UtilityVM) HasConfidentialPolicy() bool {
switch opts := uvm.createOpts.(type) {
case OptionsWCOW:
case *OptionsWCOW:
return opts.SecurityPolicyEnabled
case OptionsLCOW:
case *OptionsLCOW:
return opts.SecurityPolicyEnabled
default:
panic("unexpected options type")
Expand Down
4 changes: 2 additions & 2 deletions internal/uvm/start.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,8 +339,8 @@ func (uvm *UtilityVM) Start(ctx context.Context) (err error) {

if uvm.HasConfidentialPolicy() && uvm.OS() == "windows" {
copts := []WCOWConfidentialUVMOpt{
WithWCOWSecurityPolicy(uvm.createOpts.(OptionsWCOW).SecurityPolicy),
WithWCOWSecurityPolicyEnforcer(uvm.createOpts.(OptionsWCOW).SecurityPolicyEnforcer),
WithWCOWSecurityPolicy(uvm.createOpts.(*OptionsWCOW).SecurityPolicy),
WithWCOWSecurityPolicyEnforcer(uvm.createOpts.(*OptionsWCOW).SecurityPolicyEnforcer),
}
if err := uvm.SetWCOWConfidentialUVMOptions(ctx, copts...); err != nil {
return err
Expand Down