rust: Fix docs.rs documentation build #431
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://docs.rs/crate/lsprotocol/1.0.0-alpha.3 does not currently work, because the docs are built without 'proposed' feature enabled. In order to fix the docs page we'll still have to cut a new release though.
debonte
reviewed
Jul 13, 2025
| rust_decimal = "1.29.1" | ||
|
|
||
| [package.metadata.docs.rs] | ||
| features = ["proposed"] |
Contributor
There was a problem hiding this comment.
@karthiknadig, given that the product also doesn't build without enabling the proposed feature, maybe we should set
[features]
default = ["proposed"]Maybe this doc-specific change wouldn't be needed in that case?
Contributor
Author
There was a problem hiding this comment.
Does it even make sense to have a proposed feature at all if the crate won't build without it?
Contributor
|
Took #435 instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://docs.rs/crate/lsprotocol/1.0.0-alpha.3 does not currently work, because the docs are built without 'proposed' feature enabled. In order to fix the docs page we'll still have to cut a new release though.