Skip to content

rust: Fix docs.rs documentation build #431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
osiewicz wants to merge 1 commit into from
Closed

rust: Fix docs.rs documentation build #431

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/rust/lsprotocol/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,3 +19,6 @@ serde_json = "1.0.93"
serde_repr = "0.1.10"
url = {version = "2.3.1", features = ["serde"]}
rust_decimal = "1.29.1"

[package.metadata.docs.rs]
features = ["proposed"]
Copy link
Contributor

@debonte debonte Jul 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@karthiknadig, given that the product also doesn't build without enabling the proposed feature, maybe we should set

[features]
default = ["proposed"]

Maybe this doc-specific change wouldn't be needed in that case?

Copy link
Contributor Author

@osiewicz osiewicz Jul 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it even make sense to have a proposed feature at all if the crate won't build without it?