chore: fix roll_browser script#34886
Merged
mxschmitt merged 1 commit intomicrosoft:mainfrom Feb 21, 2025
Merged
Conversation
mxschmitt
force-pushed
the
fix-roll-script
branch
from
d9402ae to
c854925
Compare
Contributor
Test results for "tests 1"7 flaky38671 passed, 794 skipped Merge workflow run. |
Skn0tt
approved these changes
Feb 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the following GitHub Actions workflow (that the README/deviceDescriptor.json didn't get updated).
The issue was that we need the headless browser for updating the README files via
npm run docbut we never installed the never revision because only the'chromium'entry got updated, not the'chromium-headless-shell'entry in the browsers.json.This patch fixes the updating logic and by that we don't need a manual hack for updating the browserVersion/revision later on, we can instead filter for it in the beginning.
Drive-by: Adjust how
npm run docgot called. This should not have any logical changes, just cosmetics.This regressed in #34659.