Skip to content

Conversation

anupriya13
Copy link
Contributor

@anupriya13 anupriya13 commented Sep 29, 2025

Description

To fix scrollview recent regression [snapAlignmnet and snapToInterval] and cherry-pick parity [onMomentumScrollBegon and onMomentumScrollEnd]

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

Why

Cherrypicks 34d1771
Revert 6bd0793 and 2cde3f1

To fix scrollview recent regression and cherry-pick parity
Resolves #15171 and #15177

Changelog

Should this change be included in the release notes: no

Add a brief summary of the change to use in the release notes for the next release.

anupriya13 and others added 3 commits September 26, 2025 13:19
…rollView (microsoft#15104)

* Initial plan

* Implement onMomentumScrollEnd and onMomentumScrollBegin for Fabric ScrollView

Co-authored-by: anupriya13 <[email protected]>

* Add change file for momentum scroll implementation

Co-authored-by: anupriya13 <[email protected]>

* Add momentum scroll events test to playground ScrollView sample

Co-authored-by: anupriya13 <[email protected]>

* Remove vnext/codegen directory changes as requested

Co-authored-by: anupriya13 <[email protected]>

* Update CompositionContextHelper.cpp

* Update CompositionContextHelper.cpp

* Update CompositionContextHelper.cpp

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: anupriya13 <[email protected]>
@anupriya13 anupriya13 marked this pull request as ready for review September 29, 2025 03:28
@anupriya13 anupriya13 requested review from a team as code owners September 29, 2025 03:28
Copy link
Contributor

@vineethkuttan vineethkuttan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@HariniMalothu17
Copy link
Contributor

Lgtm

@sundaramramaswamy
Copy link
Contributor

Please fix the PR description; snip out template strings given for guidance. Refer comment on your other PR for details.

Copy link
Contributor

@sundaramramaswamy sundaramramaswamy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix aforementioned comment.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Author Feedback The issue/PR needs activity from its author (label drives bot activity) label Sep 30, 2025
@anupriya13 anupriya13 changed the title Cherrypick and revert PRs for stable 0.80 Cherrypick Scrollview parity and revert Scrollview regression PRs for stable 0.80 Sep 30, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs: Author Feedback The issue/PR needs activity from its author (label drives bot activity) label Sep 30, 2025
@anupriya13
Copy link
Contributor Author

@sundaramramaswamy updated please check

@anupriya13 anupriya13 merged commit d4e9a62 into microsoft:0.80-stable Sep 30, 2025
91 checks passed
protikbiswas100 pushed a commit that referenced this pull request Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants