-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Cherrypick Scrollview parity and revert Scrollview regression PRs for stable 0.80 #15183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cherrypick Scrollview parity and revert Scrollview regression PRs for stable 0.80 #15183
Conversation
…icrosoft#14841)" This reverts commit 6bd0793.
…crosoft#14847)" This reverts commit 2cde3f1.
…rollView (microsoft#15104) * Initial plan * Implement onMomentumScrollEnd and onMomentumScrollBegin for Fabric ScrollView Co-authored-by: anupriya13 <[email protected]> * Add change file for momentum scroll implementation Co-authored-by: anupriya13 <[email protected]> * Add momentum scroll events test to playground ScrollView sample Co-authored-by: anupriya13 <[email protected]> * Remove vnext/codegen directory changes as requested Co-authored-by: anupriya13 <[email protected]> * Update CompositionContextHelper.cpp * Update CompositionContextHelper.cpp * Update CompositionContextHelper.cpp --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: anupriya13 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Lgtm |
Please fix the PR description; snip out template strings given for guidance. Refer comment on your other PR for details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix aforementioned comment.
@sundaramramaswamy updated please check |
Description
To fix scrollview recent regression [snapAlignmnet and snapToInterval] and cherry-pick parity [onMomentumScrollBegon and onMomentumScrollEnd]
Type of Change
Why
Cherrypicks 34d1771
Revert 6bd0793 and 2cde3f1
To fix scrollview recent regression and cherry-pick parity
Resolves #15171 and #15177
Changelog
Should this change be included in the release notes: no
Add a brief summary of the change to use in the release notes for the next release.