Add settings for "notifying" on "activity"#20014
Open
carlos-zamora wants to merge 2 commits intodev/cazamor/toast/basefrom
Open
Add settings for "notifying" on "activity"#20014carlos-zamora wants to merge 2 commits intodev/cazamor/toast/basefrom
carlos-zamora wants to merge 2 commits intodev/cazamor/toast/basefrom
Conversation
4357c17 to
aeb531f
Compare
47c0ae7 to
09c47c6
Compare
09c47c6 to
98a4ccb
Compare
Member
Author
|
Tested this out, it's pretty cool. The only thing I can think of is the possibility of adding the So yeah, marked this as ready for review. Enjoy y'all! 😊 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the proposal in this comment. It adds 3 settings:
notifyOnInactiveOutput: send a "notification"(below) of some kind when an inactive tab has new output.notifyOnNextPrompt: Similarly, but when we get a new prompt start (requires shell integration)autoDetectRunningCommand: attempt to automatically detect the progress state of this profileFor the
notifyOn*settings, they take any combination of the following flags:tab: flash the taskbaraudible: emit an audible bell (This will use the sounds from bellSounds, if specified)taskbar: display an icon in the tab (ala terminal activity indicator/alert when in background #7955 (comment) ) (basically, similar to the bell icon)notification: send a desktop "toast" (read: notification). Clicking that notification will focus the tab that sent itFor the
autoDetectRunningCommandsetting, we support:disabled: don't do thisautomatic: (requires shell integration) if we got a FTCS_COMMAND_EXECUTED (133;C), then any output, set our progress state to indeterminateValidated using this config:
notifyOnInactiveOutput)notifyOnNextPrompt)autoDetectRunningCommand)Heavily based on #19935
Co-authored by @zadjii-msft