Skip to content

Add parameter validation and integration tests with CI integration #509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 36 commits into
base: master
Choose a base branch
from

Conversation

tarunramsinghani
Copy link
Contributor

@tarunramsinghani tarunramsinghani commented Aug 8, 2025

Summary

Adds comprehensive integration tests for TFX CLI with parameter validation and CI pipeline integration.

⚠️ Breaking Change

Parameter Validation: Unknown arguments now trigger errors instead of being silently ignored.

  • Before: tfx build --invalid-arg → silently ignored
  • After: tfx build --invalid-arg → shows error + help

Key Changes

  • 🧪 Integration Tests: Extension creation, build task validation, CLI argument processing
  • 🔧 Parameter Validation: Strict argument validation with helpful error messages
  • 🚀 CI Integration: Automated test execution with xUnit result publishing
  • 📁 Test Samples: Extension samples for comprehensive testing scenarios

Files Changed

  • app/lib/tfcommand.ts - Added parameter validation logic
  • tests/ - New integration test suites and sample extensions
  • .azure-pipelines/common-steps.yml - Added CI test execution
  • package.json - Added test:ci script
  • tsconfig.json - Test compilation configuration

Migration Required

Review and fix any scripts using invalid TFX CLI arguments - they will now fail with clear error messages.

Testing

@tarunramsinghani tarunramsinghani changed the title Adding integration tests Add parameter validation and integration tests with CI integration Aug 9, 2025
@microsoft microsoft deleted a comment from azure-pipelines bot Aug 9, 2025
@microsoft microsoft deleted a comment from azure-pipelines bot Aug 9, 2025
@microsoft microsoft deleted a comment from azure-pipelines bot Aug 10, 2025
@microsoft microsoft deleted a comment from azure-pipelines bot Aug 10, 2025
@microsoft microsoft deleted a comment from azure-pipelines bot Aug 10, 2025
@tarunramsinghani
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant