Add parameter validation and integration tests with CI integration

.azure-pipelines/azure-pipeline.yml

@@ -10,6 +10,14 @@ trigger:
 
 variables:
 - group: npm-tokens
+# Debug/verbose output variables for CLI and mock server
+- name: DEBUG_CLI_OUTPUT
+  value: 'false'
+- name: DEBUG_MOCKSERVER_OUTPUT
+  value: 'false'
+# Enable verbose tracing for TFX CLI (if supported)
+- name: TFX_TRACE
+  value: ''
 resources:
   repositories:
   - repository: 1ESPipelineTemplates

.azure-pipelines/common-steps.yml

@@ -17,11 +17,34 @@ steps:
   - script: npm i -g [email protected] --force
     displayName: Use npm version 8.19.4
 
+  - bash: |
+      cd packages/tfs-mock-server
+      npm ci
+      npm run build
+    displayName: Install and Build Mock Server
+
   - bash: |
       npm ci
       npm run build
     displayName: Build TFX CLI
 
+  - bash: |
+      export DEBUG_CLI_OUTPUT="$DEBUG_CLI_OUTPUT"
+      export DEBUG_MOCKSERVER_OUTPUT="$DEBUG_MOCKSERVER_OUTPUT"
+      export TFX_TRACE="$TFX_TRACE"
+      npm run test:ci
+    displayName: Run Tests
+    continueOnError: true
+
+  - task: PublishTestResults@2
+    displayName: Publish Test Results
+    condition: succeededOrFailed()
+    inputs:
+      testResultsFormat: 'JUnit'
+      testResultsFiles: 'test-results.xml'
+      failTaskOnFailedTests: true
+      testRunTitle: 'TFX CLI Tests'
+
   # Generate a pipeline artifact so we can publish the package manually if there are issues with automation
   - bash: |
       npm pack

.azure-pipelines/multi-os-matrix.yml

@@ -0,0 +1,105 @@
+# Multi-OS/Node matrix pipeline for tfs-cli
+trigger: none
+
+variables:
+- name: DEBUG_CLI_OUTPUT
+  value: 'false'
+- name: DEBUG_MOCKSERVER_OUTPUT
+  value: 'false'
+- name: TFX_TRACE
+  value: ''
+
+stages:
+- stage: matrix_test
+  displayName: Matrix Test
+  jobs:
+    - job: matrix
+      displayName: Run tests on all Node/OS combinations
+      strategy:
+        matrix:
+          windows_node16:
+            imageName: 'windows-2022'
+            nodeVersion: '16.x'
+          windows_node20:
+            imageName: 'windows-2022'
+            nodeVersion: '20.x'
+          ubuntu_node16:
+            imageName: 'ubuntu-24.04'
+            nodeVersion: '16.x'
+          ubuntu_node20:
+            imageName: 'ubuntu-24.04'
+            nodeVersion: '20.x'
+          macos_node16:
+            imageName: 'macos-14'
+            nodeVersion: '16.x'
+          macos_node20:
+            imageName: 'macos-14'
+            nodeVersion: '20.x'
+      pool:
+        vmImage: $(imageName)
+      steps:
+        - checkout: self
+          clean: true
+        - task: UseNode@1
+          displayName: Use Node $(nodeVersion)
+          inputs:
+            version: '$(nodeVersion)'
+        - task: NpmAuthenticate@0
+          inputs:
+            workingFile: .npmrc
+        - script: |
+            if [[ "$(nodeVersion)" =~ ^(10|12|14|16|18) ]]; then
+              npm i -g [email protected] --force
+              npm --version
+            else
+              npm i -g npm@10 --force
+              npm --version
+            fi
+          displayName: Use compatible npm version for Node (Linux/macOS)
+          condition: ne( variables['Agent.OS'], 'Windows_NT' )
+        - script: |
+            if "%nodeVersion%" == "16.x" (
+              npm i -g [email protected] --force
+              npm --version
+            ) else if "%nodeVersion%" == "20.x" (
+              npm i -g npm@10 --force
+              npm --version
+            ) else (
+              npm --version
+            )
+          displayName: Use compatible npm version for Node (Windows)
+          condition: eq( variables['Agent.OS'], 'Windows_NT' )
+        - script: npm ci
+          displayName: npm ci
+        - script: npm run build
+          displayName: Build TFX CLI
+        - script: |
+            export DEBUG_CLI_OUTPUT="$DEBUG_CLI_OUTPUT"
+            export DEBUG_MOCKSERVER_OUTPUT="$DEBUG_MOCKSERVER_OUTPUT"
+            export TFX_TRACE="$TFX_TRACE"
+            npm run test:ci
+          displayName: Run Tests (Linux/macOS)
+          condition: ne( variables['Agent.OS'], 'Windows_NT' )
+          env:
+            DEBUG_CLI_OUTPUT: $(DEBUG_CLI_OUTPUT)
+            DEBUG_MOCKSERVER_OUTPUT: $(DEBUG_MOCKSERVER_OUTPUT)
+            TFX_TRACE: $(TFX_TRACE)
+        - script: |
+            set DEBUG_CLI_OUTPUT=%DEBUG_CLI_OUTPUT%
+            set DEBUG_MOCKSERVER_OUTPUT=%DEBUG_MOCKSERVER_OUTPUT%
+            set TFX_TRACE=%TFX_TRACE%
+            npm run test:ci
+          displayName: Run Tests (Windows)
+          condition: eq( variables['Agent.OS'], 'Windows_NT' )
+          env:
+            DEBUG_CLI_OUTPUT: $(DEBUG_CLI_OUTPUT)
+            DEBUG_MOCKSERVER_OUTPUT: $(DEBUG_MOCKSERVER_OUTPUT)
+            TFX_TRACE: $(TFX_TRACE)
+        - task: PublishTestResults@2
+          displayName: Publish Test Results
+          condition: succeededOrFailed()
+          inputs:
+            testResultsFormat: 'JUnit'
+            testResultsFiles: 'test-results.xml'
+            failTaskOnFailedTests: true
+            testRunTitle: 'TFX CLI Tests (Matrix)'

.gitignore

@@ -1,6 +1,15 @@
 # Build and Packaging
 _build
 
+# Tests
+_tests
+test-results.xml
+tfs-cli.code-workspace
+
+# Mock server package build output
+packages/tfs-mock-server/lib/
+packages/tfs-mock-server/node_modules/
+
 # Logs
 logs
 *.log

.mocharc.json

@@ -0,0 +1,5 @@
+{
+  "slow": 2000,
+  "timeout": 60000,
+  "reporter": "spec"
+}

README.md

@@ -106,27 +106,173 @@ queue time      : Fri Aug 21 2015 15:07:49 GMT-0400 (Eastern Daylight Time)
 
 If you used `--save` to set a default value for an option, you may need to override it by explicitly providing a different value. You can clear any saved settings by running `tfx reset`.
 
-### Troubleshooting
 
-To see detailed tracing output, set a value for the `TFX_TRACE` environment variable and then run commands. This may provide clues to the issue and can be helpful when logging an issue.
+### Troubleshooting & Verbose Logging
 
-### Troubleshooting on Linux/OSX
+#### CLI Trace Output
+To see detailed tracing output from the CLI, set the `TFX_TRACE` environment variable and then run commands. This may provide clues to the issue and can be helpful when logging an issue.
 
+**Linux/OSX:**
 ```bash
 export TFX_TRACE=1
 ```
+**Windows:**
+```bash
+set TFX_TRACE=1
+```
+**PowerShell:**
+```bash
+$env:TFX_TRACE=1
+```
 
-### Troubleshooting on Windows
+#### Debug Output from Tests
+To enable detailed debug output for all CLI commands executed during tests, set the `DEBUG_CLI_OUTPUT` environment variable to `true`:
 
+**Linux/OSX:**
 ```bash
-set TFX_TRACE=1
+export DEBUG_CLI_OUTPUT=true
+```
+**Windows:**
+```bash
+set DEBUG_CLI_OUTPUT=true
 ```
+**PowerShell:**
+```bash
+$env:DEBUG_CLI_OUTPUT='true'
+```
+This will print detailed command execution logs for every CLI call made by the test suite.
 
-#### PowerShell
+#### Mock Server Verbose Logging
+To enable verbose logging for the integrated mock server (used in server integration tests), set the `DEBUG_MOCKSERVER_OUTPUT` environment variable to `true`:
 
+**Linux/OSX:**
 ```bash
-$env:TFX_TRACE=1
+export DEBUG_MOCKSERVER_OUTPUT=true
+```
+**Windows:**
+```bash
+set DEBUG_MOCKSERVER_OUTPUT=true
+```
+**PowerShell:**
+```bash
+$env:DEBUG_MOCKSERVER_OUTPUT='true'
+```
+This will print detailed request/response and lifecycle logs from the mock server during test runs.
+
+All three variables (`TFX_TRACE`, `DEBUG_CLI_OUTPUT`, `DEBUG_MOCKSERVER_OUTPUT`) are also available as pipeline variables in the Azure DevOps pipeline and default to `false`.
+
+## Development
+
+### Building from Source
+
+To build the project from source:
+
+1. **Install dependencies:**
+   ```bash
+   npm install
+   ```
+
+2. **Build the main project:**
+   ```bash
+   npm run build
+   ```
+
+   This compiles the TypeScript source files in the `app/` directory to JavaScript in the `_build/` directory using the TypeScript compiler and copies necessary files.
+
+3. **Clean build artifacts (optional):**
+   ```bash
+   npm run clean
+   ```
+
+### Testing
+
+The project includes comprehensive tests, including server integration tests with an integrated mock server. To run them:
+
+1. **Build the project first (required):**
+   ```bash
+   npm run build
+   ```
+
+2. **Run all tests:**
+   ```bash
+   npm test
+   ```
+
+   This builds the test files and runs all test suites.
+
+3. **Run specific test suites:**
+   ```bash
+   npm run test:build-commands
+   npm run test:extension-commands
+   npm run test:commandline
+   npm run test:server-integration
+   ```
+
+4. **Run tests with CI reporter:**
+   ```bash
+   npm run test:ci
+   ```
+
+**Note:** The mock server is now integrated as part of the test suite in the `tests/mock-server/` directory and is automatically compiled when running tests. No separate build step is required for the mock server.
+
+### Enabling Mock Server Verbose Logging
+
+For debugging server integration tests, you can enable verbose logging for the mock server to see detailed request/response information. This requires modifying the test files temporarily:
+
+1. **Locate the test file** you want to debug (e.g., `tests/server-integration-login.ts`)
+
+2. **Find the `createMockServer` call** in the `before()` hook:
+   ```typescript
+   // Current call
+   mockServer = await createMockServer({ port: 8084 });
+
+   // Add verbose option
+   mockServer = await createMockServer({ port: 8084, verbose: true });
+   ```
+
+3. **Run the specific test** to see verbose output:
+   ```bash
+   npm run test:server-integration-login
+   ```
+
+4. **Verbose output will include:**
+   - HTTP method and path for each request
+   - Authorization headers (with tokens obscured for security)
+   - Mock server lifecycle events
+   - Request processing details
+
+**Example verbose output:**
 ```
+Mock DevOps server listening on http://localhost:8084
+Mock Server: GET /_apis/connectionData - Authorization: Basic tes***ass
+Mock Server: POST /_apis/build/builds - Authorization: Bearer abc***xyz
+Mock DevOps server closed
+```
+
+**Important:** Remember to remove the `verbose: true` option before committing your changes, as it's intended for debugging purposes only.
+
+### Testing Your Changes Locally
+
+After building, you can test your changes locally in several ways:
+
+1. **Using Node.js directly:**
+   ```bash
+   node _build/tfx-cli.js
+   node _build/tfx-cli.js --help
+   ```
+
+2. **Using npm link for global installation:**
+   ```bash
+   npm link
+   tfx
+   ```
+
+   **To remove the link when done testing:**
+   ```bash
+   npm unlink -g tfx-cli
+   ```
+
+The built executable is located at `_build/tfx-cli.js` and serves as the main entry point for the CLI.
 
 ## Contributing
 

app/exec/extension/_lib/vsix-manifest-builder.ts

@@ -258,13 +258,13 @@ export class VsixManifestBuilder extends ManifestBuilder {
 				});
 				break;
 			case "details":
-				if (_.isObject(value) && value.path) {
+				if (_.isObject(value) && (value as any).path) {
 					let fileDecl: FileDeclaration = {
-						path: value.path,
+						path: (value as any).path,
 						addressable: true,
 						auto: true,
 						assetType: "Microsoft.VisualStudio.Services.Content.Details",
-						contentType: value.contentType,
+						contentType: (value as any).contentType,
 					};
 					this.addFile(fileDecl, true);
 				}
@@ -304,7 +304,7 @@ export class VsixManifestBuilder extends ManifestBuilder {
 				break;
 			case "repository":
 				if (_.isObject(value)) {
-					const { type, url, uri } = value;
+					const { type, url, uri } = value as any;
 					if (!type) {
 						throw new Error("Repository must have a 'type' property.");
 					}

app/exec/extension/init.ts

@@ -4,7 +4,7 @@ import jsonInPlace from "json-in-place";
 import { promisify } from "util";
 import { TfCommand } from "../../lib/tfcommand";
 import * as args from "../../lib/arguments";
-import * as colors from "colors";
+import colors = require("colors");
 import * as extBase from "./default";
 import * as fs from "fs";
 import * as http from "https";