Fix typo in isRequiredInitializedParameter #1598
Merged
+88
−109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a critical typo in the isRequiredInitializedParameter function where a missing ! operator was incorrectly negating the strictNullChecks condition. The fix enables a previously disabled assertion that ensures getOptionalType is only called when strict null checks are enabled.
Key changes:
- Fixed boolean logic in
isRequiredInitializedParameterby adding the missing!operator - Re-enabled an assertion in
getOptionalTypethat was commented out due to the bug
Reviewed Changes
Copilot reviewed 24 out of 24 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| internal/checker/emitresolver.go | Fixed the typo by adding missing ! operator to strictNullChecks condition |
| internal/checker/checker.go | Re-enabled assertion that ensures getOptionalType is only called with strict null checks |
| Multiple test baseline files | Updated test baselines showing corrected type emission behavior, particularly around parameter type declarations with ` |
gabritto
approved these changes
Aug 18, 2025
jakebailey
approved these changes
Aug 18, 2025
Comment on lines
+80
to
+82
| export declare function fnWithPartialAnnotationOnDefaultparam(x: { | ||
| name: string; | ||
| } | undefined, b: number): void; |
There was a problem hiding this comment.
Interesting that we are losing P here; I assume this is a reuse problem?
There was a problem hiding this comment.
Yep - we just swapped the diff caused by lacking node reuse logic from the strict: false case to strict: true.
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #1593 enabling another assertion, which points out a missing
!inisRequiredInitializedParameter.