Engineering - ensure that the pipeline fails if the pwsh tasks fail #1143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR ensures that Azure DevOps pipeline failures are properly detected by configuring PowerShell scripts to stop on errors. This prevents silent failures that could lead to incomplete or corrupted builds being released.
Key Changes
- Adds
$ErrorActionPreference = "Stop"to PowerShell tasks in both release and pre-release pipelines - Ensures pipeline fails immediately when any PowerShell command encounters an error
- Applies the fix consistently across all PowerShell tasks that handle OAuth token extraction and repository operations
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| build/release.yml | Adds error handling configuration to three PowerShell tasks for proper pipeline failure detection |
| build/pre-release.yml | Adds error handling configuration to three PowerShell tasks for proper pipeline failure detection |
alexr00
previously approved these changes
Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.