Skip to content

Engineering - ensure that the pipeline fails if the pwsh tasks fail #1143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Engineering - ensure that the pipeline fails if the pwsh tasks fail #1143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eae4e24
Engineering - ensure that the pipeline fails if the pwsh tasks fail
lszomoru Sep 25, 2025
378fe67
Switch to a bash script
lszomoru Sep 25, 2025
91d7793
Remove code
lszomoru Sep 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions build/mixin-completions-core.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
#!/bin/bash
set -e

# Get the OAuth token from the git config
result=$(git config --get-regexp '.*extraheader' '^AUTHORIZATION:')
basicToken=$(echo "$result" | sed 's/.*AUTHORIZATION: basic //')
oauthToken=$(echo "$basicToken" | base64 -d | cut -d':' -f2)

# Get the completions core version from package.json
completionsCoreVersion=$(node -p "require('./package.json').completionsCore")

# Clone the vscode-copilot-completions repository
git clone -b completions-port "https://vscode:[email protected]/microsoft/vscode-copilot-completions.git" --depth 1 src/extension/completions-core

# Navigate to the cloned directory and checkout the specific version
pushd src/extension/completions-core
git checkout "$completionsCoreVersion"
popd

# Remove the existing file and rename the .txt version
rm src/extension/completions/vscode-node/completionsCoreContribution.ts
mv src/extension/completions/vscode-node/completionsCoreContribution.ts.txt src/extension/completions/vscode-node/completionsCoreContribution.ts
26 changes: 2 additions & 24 deletions build/pre-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,18 +97,7 @@ extends:
Remove-Item -Recurse -Force ../vscode-capi
displayName: mixin

- pwsh: |
$result = git config --get-regexp .*extraheader ^AUTHORIZATION:
$basicToken = $result -split "AUTHORIZATION: basic " | Select-Object -Last 1
$oauthToken = [System.Text.Encoding]::ASCII.GetString([System.Convert]::FromBase64String($basicToken)) -split ":" | Select-Object -Last 1
$PackageJson = Get-Content -Path package.json -Raw | ConvertFrom-Json
$CompletionsCoreVersion = $PackageJson.completionsCore
git clone -b completions-port https://vscode:[email protected]/microsoft/vscode-copilot-completions.git --depth 1 src/extension/completions-core
pushd src/extension/completions-core
git checkout $CompletionsCoreVersion
popd
rm src/extension/completions/vscode-node/completionsCoreContribution.ts
mv src/extension/completions/vscode-node/completionsCoreContribution.ts.txt src/extension/completions/vscode-node/completionsCoreContribution.ts
- script: ./build/mixin-completions-core.sh
condition: and(succeeded(), eq(${{ parameters.mixinCompletionsCore }}, true))
displayName: Mixin the completions core repo

Expand Down Expand Up @@ -176,18 +165,7 @@ extends:
- script: npm run setup:dotnet
displayName: Install dotnet cli

- pwsh: |
$result = git config --get-regexp .*extraheader ^AUTHORIZATION:
$basicToken = $result -split "AUTHORIZATION: basic " | Select-Object -Last 1
$oauthToken = [System.Text.Encoding]::ASCII.GetString([System.Convert]::FromBase64String($basicToken)) -split ":" | Select-Object -Last 1
$PackageJson = Get-Content -Path package.json -Raw | ConvertFrom-Json
$CompletionsCoreVersion = $PackageJson.completionsCore
git clone -b completions-port https://vscode:[email protected]/microsoft/vscode-copilot-completions.git --depth 1 src/extension/completions-core
pushd src/extension/completions-core
git checkout $CompletionsCoreVersion
popd
rm src/extension/completions/vscode-node/completionsCoreContribution.ts
mv src/extension/completions/vscode-node/completionsCoreContribution.ts.txt src/extension/completions/vscode-node/completionsCoreContribution.ts
- script: ./build/mixin-completions-core.sh
condition: and(succeeded(), eq(${{ parameters.mixinCompletionsCore }}, true))
displayName: Mixin the completions core repo

Expand Down
26 changes: 2 additions & 24 deletions build/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,18 +99,7 @@ extends:
Remove-Item -Recurse -Force ../vscode-capi
displayName: mixin

- pwsh: |
$result = git config --get-regexp .*extraheader ^AUTHORIZATION:
$basicToken = $result -split "AUTHORIZATION: basic " | Select-Object -Last 1
$oauthToken = [System.Text.Encoding]::ASCII.GetString([System.Convert]::FromBase64String($basicToken)) -split ":" | Select-Object -Last 1
$PackageJson = Get-Content -Path package.json -Raw | ConvertFrom-Json
$CompletionsCoreVersion = $PackageJson.completionsCore
git clone -b completions-port https://vscode:[email protected]/microsoft/vscode-copilot-completions.git --depth 1 src/extension/completions-core
pushd src/extension/completions-core
git checkout $CompletionsCoreVersion
popd
rm src/extension/completions/vscode-node/completionsCoreContribution.ts
mv src/extension/completions/vscode-node/completionsCoreContribution.ts.txt src/extension/completions/vscode-node/completionsCoreContribution.ts
- script: ./build/mixin-completions-core.sh
condition: and(succeeded(), eq(${{ parameters.mixinCompletionsCore }}, true))
displayName: Mixin the completions core repo

Expand Down Expand Up @@ -178,18 +167,7 @@ extends:
- script: npm run setup:dotnet
displayName: Install dotnet cli

- pwsh: |
$result = git config --get-regexp .*extraheader ^AUTHORIZATION:
$basicToken = $result -split "AUTHORIZATION: basic " | Select-Object -Last 1
$oauthToken = [System.Text.Encoding]::ASCII.GetString([System.Convert]::FromBase64String($basicToken)) -split ":" | Select-Object -Last 1
$PackageJson = Get-Content -Path package.json -Raw | ConvertFrom-Json
$CompletionsCoreVersion = $PackageJson.completionsCore
git clone -b completions-port https://vscode:[email protected]/microsoft/vscode-copilot-completions.git --depth 1 src/extension/completions-core
pushd src/extension/completions-core
git checkout $CompletionsCoreVersion
popd
rm src/extension/completions/vscode-node/completionsCoreContribution.ts
mv src/extension/completions/vscode-node/completionsCoreContribution.ts.txt src/extension/completions/vscode-node/completionsCoreContribution.ts
- script: ./build/mixin-completions-core.sh
condition: and(succeeded(), eq(${{ parameters.mixinCompletionsCore }}, true))
displayName: Mixin the completions core repo

Expand Down
Loading