Skip to content

Conversation

eleanorjboyd
Copy link
Member

fixes #25366

@eleanorjboyd eleanorjboyd self-assigned this Sep 18, 2025
@eleanorjboyd eleanorjboyd added bug Issue identified by VS Code Team member as probable bug area-testing labels Sep 18, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the _resolveExecution method in PythonResultResolver to eliminate performance bottlenecks that were causing stack overflow issues with parameterized tests. The optimization replaces O(nmk) complexity tree rebuilding with efficient O(1) map-based lookups for test result processing.

Key changes:

  • Replaces expensive tree traversal with cached lookup methods using existing maps
  • Extracts outcome-specific handling into separate methods for better maintainability
  • Adds comprehensive performance test to validate the optimization

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
src/client/testing/testController/common/resultResolver.ts Refactors _resolveExecution method to use efficient lookups and extracts outcome handlers into separate methods
src/test/testing/common/testingAdapter.test.ts Adds performance test to validate efficient test result processing without tree rebuilding

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

⚠️ This PR originates from a fork. Due to security restrictions, pipelines from forks are no longer triggered automatically. Learn more.

If the changes appear safe, you can manually trigger the pipeline by commenting /AzurePipelines run.

@vs-code-engineering vs-code-engineering bot added this to the September 2025 milestone Sep 18, 2025
DonJayamanne
DonJayamanne previously approved these changes Sep 18, 2025
@eleanorjboyd eleanorjboyd enabled auto-merge (squash) September 18, 2025 22:23
Copy link

⚠️ This PR originates from a fork. Due to security restrictions, pipelines from forks are no longer triggered automatically. Learn more.

If the changes appear safe, you can manually trigger the pipeline by commenting /AzurePipelines run.

@eleanorjboyd eleanorjboyd merged commit 2968abd into microsoft:main Sep 18, 2025
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-testing bug Issue identified by VS Code Team member as probable bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test Results named pipe error: Maximum call stack size exceeded

3 participants