Fix: Replace terminal tabbed view lifecycle hack with Event.once #285657
+2
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the terminal tabbed view's focus handling to use the proper Event.once API instead of a manual lifecycle management hack. The change eliminates technical debt by leveraging VS Code's built-in event utility for one-time event listeners, ensuring the listener is automatically disposed after the first fire.
- Replaced manual event registration with
Event.oncewrapper for the connection state change listener - Removed TODO comments about lifecycle management that are now resolved
- Maintained the same functionality while improving code quality
Tyriar
requested changes
Jan 2, 2026
src/vs/workbench/contrib/terminal/browser/terminalTabbedView.ts
Outdated
Show resolved
Hide resolved
Tyriar
approved these changes
Jan 2, 2026
lszomoru
approved these changes
Jan 2, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.