Fix regression package.json task fail to re-run #286230
Merged
+5
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rzhao271
previously approved these changes
Jan 6, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a regression where tasks defined in package.json fail to re-run when invoked via the command palette. The fix modifies the restart logic to attempt running the original task when an updated task cannot be found, rather than immediately showing an error.
Key Changes:
- Modified the
_restartmethod to attempt running the original task even when_findUpdatedTaskreturns undefined - Added conditional warning display based on task execution exit code
Co-authored-by: Copilot <[email protected]>
rzhao271
previously approved these changes
Jan 6, 2026
rzhao271
previously approved these changes
Jan 6, 2026
anthonykim1
commented
Jan 6, 2026
rzhao271
approved these changes
Jan 6, 2026
meganrogge
approved these changes
Jan 6, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task from package.json fail to re-run when ran by command palette.
/cc @meganrogge
Resolves: #270296