Skip to content

Fix regression package.json task fail to re-run #286230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anthonykim1 merged 8 commits into from
Jan 7, 2026
+5 −2
Merged

Fix regression package.json task fail to re-run #286230

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
85a2b77
Fix regression package.json task fail to re-run
anthonykim1 Jan 6, 2026
f673ff1
Update src/vs/workbench/contrib/tasks/browser/abstractTaskService.ts
anthonykim1 Jan 6, 2026
0115e81
revert copilot changes
anthonykim1 Jan 6, 2026
e378241
check for 1 or 127 for command not found
anthonykim1 Jan 6, 2026
ac57977
Check to see if exitCode is none zero when showing warning
anthonykim1 Jan 6, 2026
ee50519
Update to only watch for 1 or 127
anthonykim1 Jan 6, 2026
da17e36
use !success || (success.exitCode !== undefined && success.exitCode !…
anthonykim1 Jan 6, 2026
1d51916
Use typeof success.exitCode number
anthonykim1 Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/vs/workbench/contrib/tasks/browser/abstractTaskService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2190,8 +2190,11 @@ export abstract class AbstractTaskService extends Disposable implements ITaskSer
if (updatedTask) {
await this.run(updatedTask);
} else {
// Task no longer exists, show warning
this._notificationService.warn(nls.localize('TaskSystem.taskNoLongerExists', 'Task {0} no longer exists or has been modified. Cannot restart.', task.configurationProperties.name));
const success = await this.run(task);
if (!success || (typeof success.exitCode === 'number' && success.exitCode !== 0)) {
// Task no longer exists, show warning
this._notificationService.warn(nls.localize('TaskSystem.taskNoLongerExists', 'Task {0} no longer exists or has been modified. Cannot restart.', task.configurationProperties.name));
}
}
} catch {
// eat the error, we don't care about it here
Expand Down
Loading