Add sendSignal to commandsToSkipShell defaults #291914
Merged
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeschli
approved these changes
Jan 30, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes an issue where the workbench.action.terminal.sendSignal command doesn't work when bound to a keybinding in the terminal without manually adding it to the terminal.integrated.commandsToSkipShell setting.
Changes:
- Adds
TerminalCommandId.SendSignalto theDEFAULT_COMMANDS_TO_SKIP_SHELLarray, ensuring that the sendSignal command is handled by VS Code rather than being sent to the shell
| TerminalCommandId.FocusHover, | ||
| AccessibilityCommandId.OpenAccessibilityHelp, | ||
| TerminalCommandId.StopVoice, | ||
| TerminalCommandId.SendSignal, |
There was a problem hiding this comment.
The placement of TerminalCommandId.SendSignal breaks the alphabetical ordering of the array. It should be placed immediately after TerminalCommandId.SendSequence (line 539) to maintain consistency with the rest of the list, where commands are generally sorted alphabetically by their suffix (Clear, Copy*, Delete*, Focus*, Kill*, Move*, New*, Paste*, Resize*, Run*, Scroll*, Select*, Send*, Split*, Toggle).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #291913