Skip to content

Add sendSignal to commandsToSkipShell defaults #291914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Tyriar merged 1 commit into from
Jan 30, 2026
Merged

Add sendSignal to commandsToSkipShell defaults #291914

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/vs/workbench/contrib/terminal/common/terminal.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -548,6 +548,7 @@ export const DEFAULT_COMMANDS_TO_SKIP_SHELL: string[] = [
TerminalCommandId.FocusHover,
AccessibilityCommandId.OpenAccessibilityHelp,
TerminalCommandId.StopVoice,
TerminalCommandId.SendSignal,
Copy link

Copilot AI Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The placement of TerminalCommandId.SendSignal breaks the alphabetical ordering of the array. It should be placed immediately after TerminalCommandId.SendSequence (line 539) to maintain consistency with the rest of the list, where commands are generally sorted alphabetically by their suffix (Clear, Copy*, Delete*, Focus*, Kill*, Move*, New*, Paste*, Resize*, Run*, Scroll*, Select*, Send*, Split*, Toggle).

Copilot uses AI. Check for mistakes.
'workbench.action.tasks.rerunForActiveTerminal',
'editor.action.toggleTabFocusMode',
'notifications.hideList',
Expand Down
Loading