Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 6, 2025

Replaces inline action buttons with a dropdown menu pattern to match the established style in backend-configuration-plugin/property-workers.

Changes

UI Component (workflow-cases-page.component.html)

  • Replaced 4 inline mat-icon-button elements with single more_vert menu trigger
  • Actions now render as mat-menu-item with both icon and text label
  • Added row index binding for unique element IDs

Component Configuration (workflow-cases-page.component.ts)

  • Set Actions column width to 160px matching reference pattern

E2E Tests (WorkflowCases.page.ts)

  • Updated selectors to use indexed IDs (#actionMenu-${rowNum}, #editWorkflowCaseBtn-${rowNum})
  • Modified openDelete() and openEdit() to click menu trigger before action buttons

Before/After

<!-- Before -->
<ng-template #actionsTpl let-row>
  <div class="d-flex">
    <button mat-icon-button [routerLink]="[...]"><mat-icon>edit</mat-icon></button>
    <button mat-icon-button (click)="downloadFile(...)"><mat-icon>...</mat-icon></button>
    <!-- ... more inline buttons -->
  </div>
</ng-template>

<!-- After -->
<ng-template #actionsTpl let-row let-i="index">
  <div class="workflow-case-actions" id="action-items-{{i}}">
    <button id="actionMenu-{{i}}" mat-icon-button [matMenuTriggerFor]="menu">
      <mat-icon>more_vert</mat-icon>
    </button>
    <mat-menu #menu="matMenu">
      <button mat-menu-item [routerLink]="[...]">
        <mat-icon>edit</mat-icon>
        <span>{{ 'Edit Workflow Case' | translate }}</span>
      </button>
      <!-- ... more menu items -->
    </mat-menu>
  </div>
</ng-template>
Original prompt

This section details on the original issue you should resolve

<issue_title>Change "Actions" to follow same style as reference pattern</issue_title>
<issue_description>Use https://github.com/microting/eform-backendconfiguration-plugin/tree/master/eform-client/src/app/plugins/modules/backend-configuration-pn/modules/property-workers/components/property-worker-table as implementation pattern to use.

eform-client/src/app/plugins/modules/workflow-pn/components/workflow-cases/workflow-cases-page</issue_description>

Comments on the Issue (you are @copilot in this section)


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI changed the title [WIP] Change actions to follow reference pattern style Refactor Actions column to use menu-based pattern following backend-configuration-plugin reference Nov 6, 2025
Copilot AI requested a review from renemadsen November 6, 2025 06:26
Copilot finished work on behalf of renemadsen November 6, 2025 06:26
@renemadsen renemadsen marked this pull request as ready for review November 6, 2025 11:35
@renemadsen renemadsen merged commit 038ccce into master Nov 6, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change "Actions" to follow same style as reference pattern

2 participants