Bump snoretoast to fix activation response with appID#375
Bump snoretoast to fix activation response with appID#375DuBistKomisch wants to merge 1 commit intomikaelbr:masterfrom
Conversation
|
This is a really great bugfix 🎉 Please merge and publish as soon as possible ❤️ |
|
Thank you so much @DuBistKomisch! |
|
Thanks for this! To just be on the safe side, I think I'll wait for KDE/snoretoast#15 and use binaries from that/build myself. |
|
Just an update, still waiting for KDE/snoretoast#15. There's an ongoing discussion there. |
|
Starting to lose hope that this will ever get merged... 😢 |
|
@mikaelbr KDE/snoretoast@8502ef0 ̶(̶t̶h̶i̶s̶ ̶i̶s̶ ̶p̶r̶e̶t̶t̶y̶ ̶m̶u̶c̶h̶ ̶w̶h̶a̶t̶ ̶t̶h̶e̶ ̶p̶a̶t̶c̶h̶ ̶b̶y̶ ̶@DuBistKomisch ̶d̶o̶e̶s̶)̶ https://binary-factory.kde.org/job/SnoreToast_Release_win64/ ̶c̶o̶u̶l̶d̶ ̶y̶o̶u̶ ̶m̶a̶y̶b̶e̶ ̶j̶u̶s̶t̶ ̶u̶p̶d̶a̶t̶e̶ ̶t̶h̶e̶ ̶s̶n̶o̶r̶e̶t̶o̶a̶s̶t̶ ̶b̶i̶n̶a̶r̶i̶e̶s̶?̶ ̶ |
|
1.5 Years later I realized that there's actually a pretty easy way to fix this, we just didn't implement SnoreToast well enough: Here's a guide: #424 this PR can be closed (as well as KDE/snoretoast#15 @DuBistKomisch) |
I've rebuilt the snoretoast binaries to include this change I've submitted upstream: KDE/snoretoast#15
This fixes #332 #326 and possibly others.
TL;DR: The pipe never got written to when the notification is activated (i.e. clicked the body or clicked an action button), so a blank response and metadata would be received in the notifier callback. This only happens when passing a custom
appID, because the default snoretoast behaviour is to install a shortcut to itself and register a background callback in the Windows registry, which uses a different mechanism which did actually write to the pipe.Action buttons on Windows are really the only advantage this library has over the built-in Electron notifications, so this is a pretty important fix for us Electron users.