Skip to content

Update proto#1728

Merged
sre-ci-robot merged 1 commit intomilvus-io:masterfrom
yhmo:ma
Dec 22, 2025
Merged

Update proto#1728
sre-ci-robot merged 1 commit intomilvus-io:masterfrom
yhmo:ma

Conversation

@yhmo
Copy link
Contributor

@yhmo yhmo commented Dec 22, 2025

PR Type

Enhancement


Description

  • Update milvus-proto submodule to latest commit

  • Incorporates protocol buffer changes from upstream


Diagram Walkthrough

flowchart LR
  oldCommit["Old commit: 15e4c99"]
  newCommit["New commit: 874a110"]
  oldCommit -- "submodule update" --> newCommit
Loading

File Walkthrough

Relevant files
Dependencies
milvus-proto
Submodule commit reference update                                               

sdk-core/src/main/milvus-proto

  • Updated git submodule reference from commit
    15e4c9995fddd24ba54947a6a71fb9e73cc877bd to
    874a110cdf037515529944485534b5db43add044
  • Pulls in latest protocol buffer definitions and changes from upstream
    milvus-proto repository
+1/-1     

Summary by CodeRabbit

  • Chores
    • Updated protocol definitions submodule reference to the latest version.

✏️ Tip: You can customize this high-level summary in your review settings.

Signed-off-by: yhmo <yihua.mo@zilliz.com>
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yhmo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai
Copy link

coderabbitai bot commented Dec 22, 2025

Walkthrough

Updated the git submodule pointer for sdk-core/src/main/milvus-proto to reference a newer commit. This change updates the dependency reference without modifying any functional code within the main repository.

Changes

Cohort / File(s) Summary
Submodule Reference Update
sdk-core/src/main/milvus-proto
Updated submodule commit pointer from 15e4c99... to 874a110...

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

  • Note: Simple submodule pointer update with no functional code changes; verification should focus on confirming the target commit is valid and intentional.

Poem

🐰 A pointer dances through the git tree,
From one commit hash to another, so free,
The submodule skips to a newer friend,
Dependencies updated—our journey's on trend! 🌿

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Update proto' is vague and lacks specificity about which proto files were updated or what the purpose of the update is. Consider using a more descriptive title that specifies the proto component being updated or the reason for the update (e.g., 'Update milvus-proto submodule to latest commit' or 'Update proto definitions for feature X').
✅ Passed checks (2 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@qodo-code-review
Copy link

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
🟢
No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
🎫 No ticket provided
  • Create ticket/issue
Codebase Duplication Compliance
Codebase context is not defined

Follow the guide to enable codebase context checks.

Custom Compliance
Generic: Comprehensive Audit Trails

Objective: To create a detailed and reliable record of critical system actions for security analysis
and compliance.

Status:
Submodule-only change: The PR only updates the milvus-proto submodule pointer, so audit-trail implications in the
upstream proto changes cannot be verified from this diff.

Referred Code
Subproject commit 874a110cdf037515529944485534b5db43add044

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Meaningful Naming and Self-Documenting Code

Objective: Ensure all identifiers clearly express their purpose and intent, making code
self-documenting

Status:
Upstream naming unknown: Because this PR only advances the milvus-proto submodule commit, any identifier naming
changes in generated/updated protos are not reviewable in this repository diff.

Referred Code
Subproject commit 874a110cdf037515529944485534b5db43add044

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Robust Error Handling and Edge Case Management

Objective: Ensure comprehensive error handling that provides meaningful context and graceful
degradation

Status:
Error paths not visible: The change is a submodule ref update, so any new/changed failure modes introduced by
upstream proto/schema changes and their handling in generated code cannot be assessed from
this diff.

Referred Code
Subproject commit 874a110cdf037515529944485534b5db43add044

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Secure Error Handling

Objective: To prevent the leakage of sensitive system information through error messages while
providing sufficient detail for internal debugging.

Status:
User errors not reviewable: With only a milvus-proto submodule commit change shown, it is not possible to verify
whether upstream changes could affect user-facing error content in downstream
generated/consuming code.

Referred Code
Subproject commit 874a110cdf037515529944485534b5db43add044

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Secure Logging Practices

Objective: To ensure logs are useful for debugging and auditing without exposing sensitive
information like PII, PHI, or cardholder data.

Status:
Logging impact unknown: Since the PR only updates the milvus-proto submodule reference, any logging-related
fields/messages introduced upstream cannot be inspected in this diff for sensitive-data
exposure.

Referred Code
Subproject commit 874a110cdf037515529944485534b5db43add044

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Security-First Input Validation and Data Handling

Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent
vulnerabilities

Status:
Schema changes unreviewed: The PR updates the milvus-proto submodule commit, so potential security-relevant
schema/input-surface changes in upstream protos cannot be validated from the provided
diff.

Referred Code
Subproject commit 874a110cdf037515529944485534b5db43add044

Learn more about managing compliance generic rules or creating your own custom rules

Compliance status legend 🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

@qodo-code-review
Copy link

PR Code Suggestions ✨

No code suggestions found for the PR.

@yhmo yhmo added the lgtm label Dec 22, 2025
@sre-ci-robot sre-ci-robot merged commit eb10051 into milvus-io:master Dec 22, 2025
6 checks passed
@yhmo yhmo deleted the ma branch December 26, 2025 09:48
@coderabbitai coderabbitai bot mentioned this pull request Dec 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants