Skip to content

debug: http api error #498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shanghaikid merged 2 commits into from
Jan 19, 2026
Merged

debug: http api error #498

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab362a4
debug: http api error
shanghaikid Jan 19, 2026
6e6153b
fix: test
shanghaikid Jan 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion milvus/http/Vector.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ export function Vector<T extends Constructor<HttpBaseClient>>(Base: T) {

// if topks > 1, we need to split the results with topk
// for example, if topks = [5,5], we need to split the res.data into 2 groups, each one with 5
if (res.topks.length > 1) {
if (res.topks && res.topks.length > 1) {
const topks = res.topks;
const results = res.data;
const newResults = [];
Expand Down
2 changes: 2 additions & 0 deletions test/http/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,6 +351,8 @@ export function generateTests(
collectionName: createParams.collectionName,
});

console.log(refresh);

Copy link

@gemini-code-assist gemini-code-assist bot Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This console.log statement and the following blank line appear to be for debugging purposes. They should be removed before merging to keep the codebase clean and avoid polluting test output.

expect(refresh.code).toEqual(0);
});

Expand Down
Loading