Chore: Corepack set, permissions updates#187
Conversation
|
WalkthroughThis set of changes updates several workflow and configuration files. The Changes
Sequence Diagram(s)sequenceDiagram
participant Workflow
participant CacheDirAction
participant NodeSetupAction
participant Yarn
participant Corepack
Workflow->>CacheDirAction: Run with default paths (.cache, **/.cache)
CacheDirAction->>CacheDirAction: Cache both root and nested .cache dirs
Workflow->>NodeSetupAction: Setup Node and Yarn
NodeSetupAction->>Corepack: Enable Corepack
NodeSetupAction->>Yarn: Get cacheFolder
Workflow->>package.json: Run scripts (task, build:release, changeset:version)
package.json->>Yarn: Execute turbo, build, pack, etc.
Possibly related PRs
Poem
Tip ⚡💬 Agentic Chat (Pro Plan, General Availability)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Triggered from #187 by @black7375. Checking if we can fast forward Target branch ( commit d840ee2979fe23a0ddd97b9e182638b94ccf0d98 (HEAD -> main, origin/main)
Author: alstjr7375 <alstjr7375@daum.net>
Date: Sun Apr 20 02:13:21 2025 +0900
Chore: Internal resolution error at node16 packages #184Pull request ( commit 16e5b31d559fa2e00733e846de02c9bb3a62093a (pull_request/build-system)
Author: alstjr7375 <alstjr7375@daum.net>
Date: Sun Apr 20 04:15:16 2025 +0900
Chore: Corepack set, permissions updatesIt is possible to fast forward |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
package.json (1)
29-29: Refactor thebuild:releasescript for maintainability.
The current one-liner is hard to read and prone to quoting issues. Consider breaking it into smaller scripts or an external shell file to improve clarity and cross‑platform support.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
.github/actions/cache-dir/action.yml(2 hunks).github/actions/node-setup/action.yml(1 hunks).github/workflows/fast-forward.yml(1 hunks)package.json(2 hunks)
🔇 Additional comments (6)
.github/workflows/fast-forward.yml (1)
108-113: Scope down permissions to principle of least privilege.
Replacingwrite-allwith explicit write permissions for contents, issues, pull‑requests, packages, and statuses reduces risk by only granting what's needed. Verify if any additional scopes (e.g.,id-tokenfor OIDC or deployment permissions) are required by downstream steps..github/actions/node-setup/action.yml (1)
17-19: Enable Corepack before querying Yarn cache.
Addingcorepack enableensures the subsequentyarn config get cacheFoldercall succeeds across environments..github/actions/cache-dir/action.yml (2)
11-13: Expand default cache paths for root and nested.cache.
Switching thepathsdefault to a multi-line literal with both.cacheand**/.cacheimproves cache hit rates by covering all common locations.
26-27: Align thepathinput with multi-line defaults.
Using a YAML literal block for${{ inputs.paths }}correctly propagates all specified cache directories to theactions/cachestep.package.json (2)
12-12: Explicit Yarn invocation for thetaskscript.
Prefixingturbo runwithyarnensures consistent use of the repository’s package manager and uses the configured cache directory.
30-30: Update the changeset version script.
Switching toyarn changeset versionaligns with other Yarn‑prefixed scripts. Please confirm there are no references to the removed standalonechangesetscript elsewhere.
|
/fast-forward |
|
Triggered from #187 (comment) by @black7375. Trying to fast forward Target branch ( commit d840ee2979fe23a0ddd97b9e182638b94ccf0d98 (HEAD -> main, origin/main)
Author: alstjr7375 <alstjr7375@daum.net>
Date: Sun Apr 20 02:13:21 2025 +0900
Chore: Internal resolution error at node16 packages #184Pull request ( commit 16e5b31d559fa2e00733e846de02c9bb3a62093a (pull_request/build-system)
Author: alstjr7375 <alstjr7375@daum.net>
Date: Sun Apr 20 04:15:16 2025 +0900
Chore: Corepack set, permissions updatesFast forwarding $ git push origin 16e5b31d559fa2e00733e846de02c9bb3a62093a:main
To https://github.com/mincho-js/mincho.git
d840ee2..16e5b31 16e5b31d559fa2e00733e846de02c9bb3a62093a -> main |
Description
Attempt to fix it for changeset again
Related Issue
Summary by CodeRabbit
.cachedirectories for improved caching.Additional context
Checklist