Skip to content

Conversation

@Remi-Gau
Copy link
Collaborator

@Remi-Gau Remi-Gau commented Sep 15, 2025

  • move reference section at the end of the examples
  • avoid a duplicate (reference) heading in the landing page
  • gitignore a few files created during doc build

Notes
-----
Also sets the importances\_ and pvalues\_ attributes on the instance.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this generated a warning in the doc build

/home/circleci/project/src/hidimstat/distilled_conditional_randomization_test.py:383: SyntaxWarning: invalid escape sequence '_'
"""

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for the tips.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am sorry, I made a correction in PR #453, just for it because I was thinking that it was merged.
I hope this won't create too much conflict.

@codecov
Copy link

codecov bot commented Sep 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.08%. Comparing base (f7ac87d) to head (956a26e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #401   +/-   ##
=======================================
  Coverage   98.08%   98.08%           
=======================================
  Files          22       22           
  Lines        1148     1148           
=======================================
  Hits         1126     1126           
  Misses         22       22           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@bthirion bthirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thx.

Copy link
Collaborator

@lionelkusch lionelkusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is few things to modified.

Notes
-----
Also sets the importances\_ and pvalues\_ attributes on the instance.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for the tips.

Co-authored-by: lionel kusch <[email protected]>

References
----------
Bibliography
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you changing to Bibliography here?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Remi-Gau Can you just answer this question before merging this PR?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants