-
Notifications
You must be signed in to change notification settings - Fork 12
[DOC] move references at the end of the examples #401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
bc77bd2 to
2d074a4
Compare
| Notes | ||
| ----- | ||
| Also sets the importances\_ and pvalues\_ attributes on the instance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this generated a warning in the doc build
/home/circleci/project/src/hidimstat/distilled_conditional_randomization_test.py:383: SyntaxWarning: invalid escape sequence '_'
"""
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for the tips.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am sorry, I made a correction in PR #453, just for it because I was thinking that it was merged.
I hope this won't create too much conflict.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #401 +/- ##
=======================================
Coverage 98.08% 98.08%
=======================================
Files 22 22
Lines 1148 1148
=======================================
Hits 1126 1126
Misses 22 22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bthirion
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thx.
lionelkusch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is few things to modified.
| Notes | ||
| ----- | ||
| Also sets the importances\_ and pvalues\_ attributes on the instance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for the tips.
Co-authored-by: lionel kusch <[email protected]>
|
|
||
| References | ||
| ---------- | ||
| Bibliography |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are you changing to Bibliography here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Remi-Gau Can you just answer this question before merging this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uh oh!
There was an error while loading. Please reload this page.