Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ __pycache__
docs/_build/
docs/src/generated/
docs/src/sg_execution_times.rst
# ignore file copied during doc build
tools/documentation_developer/CONTRIBUTING.rst

# file generated by hatch
Expand Down
8 changes: 4 additions & 4 deletions CONTRIBUTING.rst
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ For testing, we recommend you install the test dependencies with pip:

.. code-block:: sh

pip install hidimstat[test]
pip install -e '.[test]'

This will install ``pytest`` and the following extensions:
``pytest-cov``, ``pytest-randomly``, ``pytest-xdist``, ``pytest-html``,
Expand All @@ -40,7 +40,7 @@ To run the examples, we recommend you install the example dependencies with pip:

.. code-block:: sh

pip install hidimstat[example]
pip install -e '.[example]'

For running the examples, it's necessary to install Matplotlib >= |MatplotlibMinVersion| and seaborn >=
|SeabornMinVersion|.
Expand All @@ -55,12 +55,12 @@ The documentation is built with Sphinx. We recommend you install the documentati

.. code-block:: sh

pip install hidimstat[doc]
pip install -e '.[doc]'

After this installation, you can build the documentation from the source using the Makefile in doc_conf:

.. code-block:: sh

make html

**For more information**, look at the `developer documentation <https://hidimstat.github.io/dev/dev/index.html>`_
**For more information**, look at the `developer documentation <https://hidimstat.github.io/dev/dev/index.html>`_
4 changes: 2 additions & 2 deletions docs/src/index.rst
Original file line number Diff line number Diff line change
Expand Up @@ -172,8 +172,8 @@ For Knockoffs Inference:
:target: https://github.com/psf/black


References
----------
Bibliography
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you changing to Bibliography here?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Remi-Gau Can you just answer this question before merging this PR?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

------------
.. bibliography:: ../tools/references.bib


Expand Down
2 changes: 1 addition & 1 deletion docs/tools/conf.py
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@

# The suffix(es) of source filenames.
# You can specify multiple suffix as a list of string:
source_suffix = [".rst", ".md"]
source_suffix = {".rst": "restructuredtext"}

# sphinxcontrib-bibtex
bibtex_bibfiles = ["../tools/references.bib"]
Expand Down
10 changes: 6 additions & 4 deletions examples/plot_2D_simulation_example.py
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,6 @@
significantly the spatial uncertainty compared to clustered inference
algorithms which consider only one spatial compression.

References
----------
.. footbibliography::

"""
import matplotlib.pyplot as plt

Expand Down Expand Up @@ -356,3 +352,9 @@ def plot(maps, titles):
# conservative. In practice, Type-1 Error guarantees seem to hold
# for a lower spatial tolerance. This is an additional benefit of clustering
# randomization.

#############################################################################
# References
# ----------
# .. footbibliography::
#
11 changes: 7 additions & 4 deletions examples/plot_diabetes_variable_importance_example.py
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,6 @@
single-level case. The aim is to see if integrating the new
statistically-controlled solution has an impact on the results.

References
----------
.. footbibliography::

"""

#############################################################################
Expand Down Expand Up @@ -255,3 +251,10 @@ def compute_pval(vim):
ax.set_xticks(range(len(diabetes.feature_names)))
ax.set_xticklabels(diabetes.feature_names)
plt.show()


#############################################################################
# References
# ----------
# .. footbibliography::
#
2 changes: 1 addition & 1 deletion src/hidimstat/distilled_conditional_randomization_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -403,7 +403,7 @@ def fit_importance(self, X, y, cv=None):
Notes
-----
Also sets the importances\_ and pvalues\_ attributes on the instance.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this generated a warning in the doc build

/home/circleci/project/src/hidimstat/distilled_conditional_randomization_test.py:383: SyntaxWarning: invalid escape sequence '_'
"""

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for the tips.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am sorry, I made a correction in PR #453, just for it because I was thinking that it was merged.
I hope this won't create too much conflict.

Also sets the ``importances_`` and ``pvalues_`` attributes on the instance.
See fit() and importance() for details on the underlying computations.
"""
if cv is not None:
Expand Down
Loading