RoundTripper wraper support for metrics collection#42
Closed
0xMALVEE wants to merge 3 commits intominio:mainfrom
Closed
RoundTripper wraper support for metrics collection#420xMALVEE wants to merge 3 commits intominio:mainfrom
0xMALVEE wants to merge 3 commits intominio:mainfrom
Conversation
klauspost
reviewed
Nov 19, 2025
Comment on lines
+53
to
+60
|
|
||
| // Optional RoundTripper wrapper function. If set, this function | ||
| // will be called with the base http.Transport, and should return | ||
| // a wrapped RoundTripper (e.g., for metrics collection). | ||
| // The wrapper will be inserted between the LoadBalancer and the | ||
| // base transport, allowing it to observe all requests with their | ||
| // selected endpoints. | ||
| WrapRoundTripper func(http.RoundTripper) http.RoundTripper |
Contributor
There was a problem hiding this comment.
Usually you'd do this by providing a custom http.Transport (or even better Roundtripper) for the client to use. Usually that is a more flexible solution to this problem.
0xMALVEE
changed the title
0xMALVEE
changed the title
0xMALVEE
changed the title
klauspost
reviewed
Nov 19, 2025
kms/client.go
Outdated
Comment on lines
+120
to
+121
| if conf.Transport != nil { | ||
| rt = conf.Transport |
Contributor
There was a problem hiding this comment.
I think there is an issue is that tlsConf is not applied here. You know, maybe just revert what I proposed - it isn't needed here.
Replace the Transport http.RoundTripper field with WrapRoundTripper func to provide a cleaner API for wrapping the base transport with custom middleware (metrics, tracing, etc.). This allows the caller to add functionality without needing to handle TLS configuration manually.
0xMALVEE
changed the title
Author
|
closing in favor of #43 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
needed for pr: https://github.com/miniohq/eos/pull/2231
fixes issue: https://github.com/miniohq/eos/issues/2143