Conversation
Member
Author
|
Alternative to #42 |
0xMALVEE
approved these changes
Nov 20, 2025
0xMALVEE
requested changes
Nov 20, 2025
0xMALVEE
requested changes
Nov 20, 2025
This commit adds the `Config.Transport` field that allows users to specify a custom `http.RoundTripper`. However, users have to create and set a TLS config on their `http.RoundTripper` implementation. `NewClient` does not use the `APIKey` or `TLS` field to try to modify the `Transport` because: - The `Transport` might be a custom type and not neccessarily a `*http.Transport`. Hence, we cannot inject a TLS config. - Even if it is a `*http.Transport`, we would have to modify its `TLSClientConfig` field which may not be expected and can lead to surprising side effects. Signed-off-by: Andreas Auernhammer <github@aead.dev>
0xMALVEE
approved these changes
Nov 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds the
Config.Transportfield that allows users to specify a customhttp.RoundTripper. However, users have to create and set a TLS config on theirhttp.RoundTripperimplementation.NewClientdoes not use theAPIKeyorTLSfield to try to modify theTransportbecause:Transportmight be a custom type and not neccessarily a*http.Transport. Hence, we cannot inject a TLS config.*http.Transport, we would have to modify itsTLSClientConfigfield which may not be expected and can lead to surprising side effects.