-
Notifications
You must be signed in to change notification settings - Fork 207
Docs updates for new Codeblock v3 docs #802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we have added support for all languages listed here in shiki docs, we should remove our current list and just add a reference to this link
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recommend adding something to note that for all features, they need to have language set first. It doesn't work when it's like this directly
```title="Title"
Code
```
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great point. I made all the options H3s under an H2 for code block options to introduce this information and make it more clear that these options only apply to code blocks. It should be apparent that you can't style inline code, but this makes it more direct.
Documentation changes
Documents all meta features available with new code blocks.
Closes
For Reviewers
When reviewing documentation PRs, please consider:
✅ Technical accuracy
✅ Clarity and completeness
✅ User experience