-
Notifications
You must be signed in to change notification settings - Fork 207
Docs updates for new Codeblock v3 docs #802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 13 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
1edd825
outline for updates
ethanpalm ecfd929
update intro
ethanpalm ee99afb
add option syntax
ethanpalm 200dd11
update title section
ethanpalm 0e96132
icon section
ethanpalm 666adcf
line highlighting and focusing
ethanpalm adc23dc
showLineNumbers
ethanpalm 80047ac
expandable
ethanpalm 75f4dcf
wrap
ethanpalm 83ba129
copyedits
ethanpalm 21b0cb4
typo
ethanpalm 4a510ef
update to lines
dks333 4382d23
add nav tag
dks333 ce16313
update md to mdx
ethanpalm 58d5cdf
support for all Shiki languages
ethanpalm daa1aea
update examples
ethanpalm afb3a3a
edit `New` tag
ethanpalm 50de02d
group code block options
ethanpalm 2e5b7e5
add more options to code block example
ethanpalm 934bc41
Merge branch 'main' into codeblock-v3-docs
ethanpalm 63791e3
add links to icon libraries
ethanpalm 17e817c
fix heading
ethanpalm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recommend adding something to note that for all features, they need to have language set first. It doesn't work when it's like this directly
```title="Title"
Code
```
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great point. I made all the options H3s under an H2 for code block options to introduce this information and make it more clear that these options only apply to code blocks. It should be apparent that you can't style inline code, but this makes it more direct.