fix: handle list-valued options in PROPERTY_MAPPING matching#230
Merged
TomKaltofen merged 2 commits intomainfrom Mar 24, 2026
Merged
fix: handle list-valued options in PROPERTY_MAPPING matching#230TomKaltofen merged 2 commits intomainfrom
TomKaltofen merged 2 commits intomainfrom
Conversation
TKaltofen
force-pushed
the
fix/property-mapping-list-valued-options
branch
from
e544aef to
5301462
Compare
TomKaltofen
reviewed
Mar 23, 2026
mloda/core/abstract_plugins/components/feature_chainer/feature_chain_parser.py
Show resolved
Hide resolved
TKaltofen
force-pushed
the
fix/property-mapping-list-valued-options
branch
from
24e15c1 to
692a1ca
Compare
Convert list values to tuples in _process_found_property_value() before wrapping in frozenset, preventing TypeError on unhashable list types while preserving element order. Closes #228
TKaltofen
force-pushed
the
fix/property-mapping-list-valued-options
branch
from
692a1ca to
713e16c
Compare
Runs list-valued options through mloda.run_all() pipeline to verify that the list-to-tuple conversion preserves element order. Two tests use different column orderings with weighted sums to prove order matters and is correctly maintained.
TKaltofen
force-pushed
the
fix/property-mapping-list-valued-options
branch
from
713e16c to
0ab42a5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_process_found_property_value()to convert list values to tuples before wrapping infrozenset, preventingTypeError: unhashable type: 'list'when using list-valued options inPROPERTY_MAPPINGTest plan
test_match_feature_group_criteria_list_valued_option,test_match_feature_group_criteria_tuple_valued_option,test_list_valued_option_preserves_order,test_scalar_option_still_workstoxrun: 2178 passed (16 pre-existing failures unrelated to this change)Closes #228