Closed
Conversation
Contributor
Havunen
commented
Feb 14, 2026
Havunen
commented
- updated dependencies
- fixed some bugs
- added more tests
Havunen
commented
Feb 14, 2026
| max_depth, | ||
| max_features.value, | ||
| min_samples_split, | ||
| min_samples_leaf, |
Contributor
Author
There was a problem hiding this comment.
min_samples_leaf was incorrectly set as min_samples_split
Owner
There was a problem hiding this comment.
Thanks! I'd have to check, but I am unsure whether these are all correctly implemented!
Contributor
Author
|
hi @mlondschien could you check these PR's. Thanks |
mlondschien
requested changes
Feb 21, 2026
Owner
mlondschien
left a comment
mlondschien
left a comment
There was a problem hiding this comment.
This looks like a lot of unecessary changes suggested by ai. Some are bs. Can you have a look and reduce this to include only the changes that are necessary?
| max_depth, | ||
| max_features.value, | ||
| min_samples_split, | ||
| min_samples_leaf, |
Owner
There was a problem hiding this comment.
Thanks! I'd have to check, but I am unsure whether these are all correctly implemented!
Havunen
commented
Feb 21, 2026
Havunen
commented
Feb 21, 2026
mlondschien
reviewed
Feb 21, 2026
Contributor
Author
|
minimized everything and squashed it into: #174 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.