Run shell as default if no arguments are given upon docker run#1
Merged
mlsdpk merged 2 commits intomlsdpk:masterfrom Mar 1, 2025
Merged
Run shell as default if no arguments are given upon docker run#1mlsdpk merged 2 commits intomlsdpk:masterfrom
mlsdpk merged 2 commits intomlsdpk:masterfrom
Conversation
mlsdpk
requested changes
Feb 23, 2025
Owner
mlsdpk
left a comment
mlsdpk
left a comment
There was a problem hiding this comment.
Thanks for this fix! Just minor changes need to be done and we're good to go. Please also update the changelog to reflect this update.
entrypoint.sh
Outdated
| source /venv/bin/activate | ||
| exec "$@" No newline at end of file | ||
| exec "$@" | ||
| exec bash No newline at end of file |
Owner
There was a problem hiding this comment.
I think this line exec bash will not be executed if the user provides custom commands. May be we could add a conditional statement to execute /bin/bash only if no command is provided so that we can still support both options (allow the container to default to an interactive shell)
mlsdpk
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
exec bashat the end of theentrypoint.sh. This will helpdocker runcommand to run open bash