Skip to content

Run shell as default if no arguments are given upon docker run #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mlsdpk merged 2 commits into from
Mar 1, 2025
Merged

Run shell as default if no arguments are given upon docker run #1

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d473c48
fix: add exec bash to make the entrypoint.sh run
ghanta1996 Feb 23, 2025
11c2359
update: add conditional check for `exec bash`
ghanta1996 Mar 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion entrypoint.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
#!/bin/bash
source /venv/bin/activate
exec "$@"
exec "$@"
exec bash
Copy link
Copy Markdown
Owner

@mlsdpk mlsdpk Feb 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this line exec bash will not be executed if the user provides custom commands. May be we could add a conditional statement to execute /bin/bash only if no command is provided so that we can still support both options (allow the container to default to an interactive shell)

Loading