Skip to content

FIX: Replace np.fromstring with np.frombuffer in GDF reader for NumPy… #13415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

FIX: Replace np.fromstring with np.frombuffer in GDF reader for NumPy… #13415

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ab866f2
FIX: Replace np.fromstring with np.frombuffer in GDF reader for NumPy…
devparikh0506 Sep 11, 2025
9e9e281
FIX: Use fid.read(1) + np.frombuffer in GDF reader to replace np.from…
devparikh0506 Sep 11, 2025
4f455ee
Merge branch 'main' into fix-gdf-fromstring
devparikh0506 Sep 11, 2025
fc98279
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mne/io/edf/edf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1443,7 +1443,7 @@ def _read_gdf_header(fname, exclude, include=None):
fid.seek(etp) # skip data to go to event table
etmode = fid.read(1).decode()
if etmode != "":
etmode = np.fromstring(etmode, UINT8).tolist()[0]
etmode = np.frombuffer(etmode.encode(), dtype=UINT8).tolist()[0]
Copy link
Member

@larsoner larsoner Sep 11, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We decode it just to encode it? Maybe we could do instead

etmode = fid.read(1)
if len(etmode):
    etmode = np.frombuffer(etmode, dtype=UINT8)[0]


if edf_info["number"] < 1.94:
sr = np.fromfile(fid, UINT8, 3)
Expand Down