Skip to content

feat: bump strip-json-comments from 3 to 5#5484

Merged
mark-wiemer merged 5 commits intomochajs:mainfrom
JoshuaKGoldberg:strip-json-comments-5
Dec 20, 2025
Merged

feat: bump strip-json-comments from 3 to 5#5484
mark-wiemer merged 5 commits intomochajs:mainfrom
JoshuaKGoldberg:strip-json-comments-5

Conversation

@JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg commented Oct 2, 2025

PR Checklist

Overview

Bumps the package from ^3.1.1 to ^5.0.3.

Similar to #5482, this increases the lockfile size for local development dependencies. This is because strip-json-comments@3 is still referenced by:

$ npm ls strip-json-comments@3
mocha@11.7.4 /Users/josh/repos/mocha
├─┬ eslint@8.56.0
│ └─┬ @eslint/eslintrc@2.1.4
│   └── strip-json-comments@3.1.1
├─┬ jsdoc@3.6.11
│ └── strip-json-comments@3.1.1
└─┬ markdownlint-cli@0.30.0
  └─┬ run-con@1.2.11
    └── strip-json-comments@3.1.1

💖

@mark-wiemer

This comment was marked as resolved.

@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request Oct 6, 2025
5 tasks
@JoshuaKGoldberg

This comment was marked as resolved.

@codecov
Copy link

codecov bot commented Nov 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.52%. Comparing base (410ce0d) to head (ac5c16f).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5484   +/-   ##
=======================================
  Coverage   93.52%   93.52%           
=======================================
  Files          57       57           
  Lines        4465     4465           
  Branches      918      918           
=======================================
  Hits         4176     4176           
  Misses        289      289           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review December 19, 2025 18:50
@mark-wiemer mark-wiemer merged commit 9b0db24 into mochajs:main Dec 20, 2025
80 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the strip-json-comments-5 branch December 20, 2025 04:19
@MrChocolatine
Copy link

How come these dependency updates are marked as "feature"?

@JoshuaKGoldberg
Copy link
Member Author

Because they change and improve the code that runs at runtime. Mocha is so widely used that even subtle changes to thinks like dependencies have broken end-users in the past. Just to be safe, we've been putting these as features.

@MrChocolatine
Copy link

Because they change and improve the code that runs at runtime. Mocha is so widely used that even subtle changes to thinks like dependencies have broken end-users in the past. Just to be safe, we've been putting these as features.

Thanks for the explanation @JoshuaKGoldberg .

lennonnikolas pushed a commit to lennonnikolas/mocha that referenced this pull request Jan 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

📦 Package: Bump strip-json-comments from 3 to 5

3 participants