build: update Rollup to v4

[Lightning00Blade]

PR Checklist

• Addresses an existing open issue: works on 🛠 Repo: Bump eslint from 8 to 9 #5483 (edited by @mark-wiemer)
• That issue was marked as status: accepting prs (edited by @mark-wiemer)
• Steps in CONTRIBUTING.md were taken

Overview

Updates rollup to v4.
This change is needed for the EsLint v9 bump - #5483.

Notable changes drops rollup-plugin-node-global and uses rollup-plugin-polyfill-node unconditionally.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.69%. Comparing base (9a70533) to head (ea3d277).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #5510   +/-   ##
=======================================
  Coverage   93.69%   93.69%           
=======================================
  Files          57       57           
  Lines        4390     4390           
  Branches      849      849           
=======================================
  Hits         4113     4113           
  Misses        277      277           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[mark-wiemer]

Just commenting some first thoughts for now, I'll need to review Rollup in more detail and test this locally to see what's going on. Might be a week-ish, I usually prioritize bugfixes first.

[mark-wiemer]

Can you clarify what this comment means?

[Lightning00Blade]

If you use Import attributes they can't be parsed by the AST builder used in EsLint v8 and it crashes the lint process.

[Lightning00Blade]

So import packageJson from "./package.json" with { type: "json" }; result is something like

Error: unexpected character `{` in X

[mark-wiemer]

why change this one? does the old import { version } from "./package.json"; no longer work? would it work if we used import { version } from "./package.json" with { type: "json" }; ?

[Lightning00Blade]

I have to double check the first part, that was something but for the Import Attributes only Default exports are possible

Note: JSON modules only have one default export. You cannot do named imports from them (like import { name } from "data.json").

MDN docs