Skip to content

build: update Rollup to v4 #5510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+974 −622
Open

build: update Rollup to v4 #5510

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a9102f0
rebase
Lightning00Blade Oct 27, 2025
ea3d277
Merge branch 'main' into build-rollup-v4
mark-wiemer Nov 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion eslint.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ module.exports = [
{
files: [
"lib/nodejs/esm-utils.js",
"rollup.config.js",
"rollup.config.mjs",
"scripts/*.mjs",
"scripts/pick-from-package-json.js",
"test/compiler-cjs/test.js",
Expand Down Expand Up @@ -176,6 +176,9 @@ module.exports = [
"test/integration/fixtures/**",
".karma/**",
"mocha.js",
// TODO: EsLint v8 parser can't parse Import attributes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you clarify what this comment means?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you use Import attributes they can't be parsed by the AST builder used in EsLint v8 and it crashes the lint process.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So import packageJson from "./package.json" with { type: "json" }; result is something like

Error: unexpected character `{` in X

"rollup.config.mjs",
"scripts/pick-from-package-json.mjs",
],
},
];
2 changes: 1 addition & 1 deletion karma.conf.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ const baseConfig = {
rollupPlugin,
],
rollup: {
configFile: "rollup.config.js",
configFile: "rollup.config.mjs",
include: ["test/**"],
},
reporters: ["mocha"],
Expand Down
Loading
Loading