build: update Rollup to v4 #5510
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5510 +/- ##
=======================================
Coverage 93.69% 93.69%
=======================================
Files 57 57
Lines 4390 4390
Branches 849 849
=======================================
Hits 4113 4113
Misses 277 277 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Lightning00Blade
force-pushed
the
build-rollup-v4
branch
from
285e5d0 to
a9102f0
Compare
| "test/integration/fixtures/**", | ||
| ".karma/**", | ||
| "mocha.js", | ||
| // TODO: EsLint v8 parser can't parse Import attributes |
There was a problem hiding this comment.
Can you clarify what this comment means?
There was a problem hiding this comment.
If you use Import attributes they can't be parsed by the AST builder used in EsLint v8 and it crashes the lint process.
There was a problem hiding this comment.
So import packageJson from "./package.json" with { type: "json" }; result is something like
Error: unexpected character `{` in X
| import pickFromPackageJson from "./scripts/pick-from-package-json"; | ||
| import { version } from "./package.json"; | ||
| import pickFromPackageJson from "./scripts/pick-from-package-json.mjs"; | ||
| import packageJson from "./package.json" with { type: "json" }; |
There was a problem hiding this comment.
why change this one? does the old import { version } from "./package.json"; no longer work? would it work if we used import { version } from "./package.json" with { type: "json" }; ?
There was a problem hiding this comment.
I have to double check the first part, that was something but for the Import Attributes only Default exports are possible
Note: JSON modules only have one default export. You cannot do named imports from them (like import { name } from "data.json").
There was a problem hiding this comment.
And to answer the first question, no you get a Error (Tested Node v20,v22,v24)
TypeError [ERR_IMPORT_ATTRIBUTE_MISSING]: Module "./package.json" needs an import attribute of "type: json"2 participants
PR Checklist
status: accepting prs(edited by @mark-wiemer)Overview
Updates rollup to v4.
This change is needed for the EsLint v9 bump - #5483.
Notable changes drops
rollup-plugin-node-globaland usesrollup-plugin-polyfill-nodeunconditionally.