Fix broken modal.com URLs: blog typos and wrong doc paths#1503
Fix broken modal.com URLs: blog typos and wrong doc paths#1503charlesfrye merged 1 commit intomainfrom
Conversation
Co-Authored-By: Rahul Chalamala <rahul@modal.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
Here are all the old → new URLs so you can click through:
|
|
@prbot approve |
|
@charlesfrye is not in the sudoers file. This incident will be reported. |
| # ## Using WebSockets to stream audio and diarization results | ||
|
|
||
| # We use a Modal [ASGI](https://modal.com/docs/guide/asgi) app to serve the diarization results | ||
| # We use a Modal [ASGI](https://modal.com/docs/guide/webhooks) app to serve the diarization results |
There was a problem hiding this comment.
🚩 ASGI link text doesn't match new webhooks destination
The link text still says [ASGI] but the URL was changed from /docs/guide/asgi to /docs/guide/webhooks. If the webhooks page doesn't cover ASGI specifics, this could be misleading to readers. The PR checklist notes this was reviewed and the old /docs/guide/asgi page no longer exists, so /docs/guide/webhooks is the closest valid destination. However, it may be worth updating the link text from ASGI to something like ASGI/webhooks to better match the destination page content.
Was this helpful? React with 👍 or 👎 to provide feedback.
|
@prbot approve rchalamala |
|
@charlesfrye is not in the sudoers file. This incident will be reported. |
|
@prbot approve @rchalamala |
Fixes 5 broken
modal.comURLs across comments in example files. All currently 404; all fixes verified to return 200.ministral3_inference.py/blog/announcing-h200-b200/blog/introducing-b200-h200vllm_inference.py/blog/announcing-h200-b200/blog/introducing-b200-h200very_large_models.py/blog/introducting-b200-h200/blog/introducing-b200-h200sortformer2_1_speaker_diarization.py/docs/guide/asgi/docs/guide/webhookssandbox_agent.py/docs/images/docs/guide/images/guide/segmentNo functional code changes — all edits are in comments only.
Link to Devin run | Requested by @rchalamala
Human Review Checklist
/docs/guide/asgipage no longer exists. Confirm/docs/guide/webhooksis the correct destination for ASGI documentation.Type of Change